-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Fix Angular 15 support and add zone.js v0.14.x support #24367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Blanc <[email protected]>
This reverts commit bd3abf2.
valentinpalkovic
requested review from
kasperpeulen,
ndelangen,
yannbf and
JReinhold
as code owners
October 4, 2023 11:34
5 tasks
valentinpalkovic
changed the title
bug: Ensure Angular 15 compatibility
Angular: Ensure Angular 15 compatibility
Oct 4, 2023
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @storybook/[email protected], @sveltejs/[email protected], @types/[email protected], [email protected], [email protected], [email protected] |
ndelangen
approved these changes
Oct 4, 2023
valentinpalkovic
changed the title
Angular: Ensure Angular 15 compatibility
Angular: Ensure Angular 15 compatibility + Add zone.js v0.14.x support
Oct 4, 2023
valentinpalkovic
changed the title
Angular: Ensure Angular 15 compatibility + Add zone.js v0.14.x support
Angular: fix Angular 15 and add zone.js v0.14.x support
Oct 4, 2023
yannbf
changed the title
Angular: fix Angular 15 and add zone.js v0.14.x support
Angular: Fix Angular 15 support and add zone.js v0.14.x support
Oct 4, 2023
yannbf
added
ci:merged
Run the CI jobs that normally run when merged.
and removed
ci:normal
labels
Oct 4, 2023
valentinpalkovic
added
ci:daily
Run the CI jobs that normally run in the daily job.
and removed
ci:merged
Run the CI jobs that normally run when merged.
ci:daily
Run the CI jobs that normally run in the daily job.
labels
Oct 5, 2023
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24357
What I did
This pull request addresses a critical dependency issue that arose with upgrading the file-system-cache package to version 2.4.0 and now having a new
types-ramda
version published yesterday. The specific version depends on @types/ramda, which, in turn, requires Typescript version 5. Our project aims to maintain compatibility with Typescript version 4 to ensure seamless integration with Storybook and Angular 15, which is scaffolded with Typescript 4.x. However, the recent changes in @types/ramda have led to a broken setup since it now utilizes types-ramda, introducing Typescript syntax exclusive to version 5. This scenario manifested yesterday, disrupting the normal operation of our development environment.To rectify this and restore the compatibility of our setup with Typescript 4.x, we are downgrading the file-system-cache package to version 2.3.0. This version does not have the problematic dependency version on @types/ramda and will ensure our setup remains functional and compatible with the existing toolchain, including Storybook and Angular 15.
Furthermore
debugWebpack
CLI option was added to the Angular builderChecklist for Contributors
Testing
Manual testing
Manual testing is not required, since it is covered by CI
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>