Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon A11y: Toggle default focus of "tests completed" button #24446

Closed
wants to merge 2 commits into from
Closed

Addon A11y: Toggle default focus of "tests completed" button #24446

wants to merge 2 commits into from

Conversation

Nevnet99
Copy link
Contributor

Closes #24129

What I did

Adds a boolean to the component that allows you to revert specific buttons to have the default focus for the button (previously it had the bottom focus rather than all around).

Manual testing

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf changed the title fix: added bool to ActionBar to toggle default focus of Tests complete button Addon A11y: Toggle default focus of "tests completed" button Oct 12, 2023
@yannbf
Copy link
Member

yannbf commented Oct 12, 2023

Hey @Nevnet99 thanks for contributing to Storybook!

There are a couple of things that are worth mentioning:

  1. What you're trying to fix might not be a bug. Please read this comment.
  2. It seems that this change introduced a side-effect in every addon panel that uses the button. Now they are always showing as if they're focused. The proposed fix doesn't seem to be the correct solution, as the original issue relates to keyboard focus being lost, while the contribution only makes visual changes to the element shown in the addon panel.

I think the issue needs a little more discussion, feel free to be part of it!

@yannbf yannbf self-assigned this Oct 12, 2023
@Nevnet99 Nevnet99 closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Keyboard focus is not visible While invoking the “Tests completed” button.
2 participants