Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel.md since Babel does not recommend babelrc #24543

Closed
wants to merge 1 commit into from

Conversation

dospore
Copy link

@dospore dospore commented Oct 21, 2023

What I did

Just a little one but just updated the documentation under the Babel docs since Babel does not recommend babelrc, babel recommends babel.config.js. Happy to change wording here but just chose something off the top of my head.

@dospore
Copy link
Author

dospore commented Oct 23, 2023

@jonniebigodes I dont know why I was thinking about this but I re-read the docs and I am not sure I am certain. So its up to the maintainers if you want to change. Babel itself uses babel.config.js but as per the docs I linked in the PR I think its "If Guy Fieri is your hero? We recommend using the babel.config.json format." lmao

@jonniebigodes
Copy link
Contributor

@dospore sorry for the delayed response on this. We've been busy here at Storybook. Hope you don't mind, but I'm going to close this as the team is working on some features related to Babel and that will require some additional changes to this documentation piece.

Hope you don't take it the wrong way and nonetheless, thank you so much for taking the time to put together this pull request and help us improve the documentation. We're thankful for it 🙏 !

Looking forward to seeing your next contribution. Hope you have a fantastic day.

Stay safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants