Svelte: use SvelteComponent instead of deprecated SvelteComponentTyped
#25725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucalves
approved these changes
Jan 25, 2024
JReinhold
added
maintenance
JReinhold
approved these changes
Jan 31, 2024
JReinhold
requested changes
Jan 31, 2024
|
Right. I missed that. All instances are changed now. |
|
Hm.. Is this breaking now? Definitely the change is larger than I thought initially. |
JReinhold
changed the title
SvelteComponent instead of deprecated SvelteComponentTypedSvelteComponent instead of deprecated SvelteComponentTyped
|
Shall we look at this together @JReinhold ? |
|
Never mind (; |
|
Thanks for your PR! Sorry for not merging it sooner, we made a new PR here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Replaced deprecated
SvelteComponentTypedwith theSvelteComponenttype.SvelteComponentTypedis deprecated since Svelte 4 (see the migration guide) and it is recommended to use theSvelteComponenttype instead.The
@storybook/sveltepackage marks Svelte 4 as lowest supported version, so it feels reasonable to migrate. Reference:storybook/code/renderers/svelte/package.json
Lines 71 to 73 in a606619
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
The change is in type test file. If I got it right,
svelte-checkis used to type check the file. Runningsvelte-checkdoes not report errors.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>