Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix custom tabs not showing in the manager #25792

Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6216569
un-memoize getTabs to always get up-to-date tabs from addons registry
JReinhold Jan 25, 2024
d6d9583
add tab=<ID> query parameter
JReinhold Jan 26, 2024
1d84cd9
make tabs work with a queryParam
ndelangen Jan 26, 2024
a7baa7a
cleanup types, remove showPanel
JReinhold Jan 29, 2024
c8c19f9
fix consistency when refresh browser an tabs/canvas hiding
ndelangen Jan 29, 2024
f4ca800
make (out) tools not show on tabs
ndelangen Jan 29, 2024
4f22662
cleanup
ndelangen Jan 29, 2024
73c9fd3
remove story, because it's not valuable, and the component now depend…
ndelangen Jan 29, 2024
0c42662
fix
ndelangen Jan 29, 2024
1057948
fix review comments and add migration notes
ndelangen Jan 31, 2024
fea21eb
Merge branch 'next' into jeppe/25322-bug-main-section-disappears-when…
ndelangen Jan 31, 2024
33fef12
Merge branch 'next' into jeppe/25322-bug-main-section-disappears-when…
ndelangen Jan 31, 2024
be19e9e
upgrade playwright
ndelangen Jan 31, 2024
1ccab20
Merge branch 'jeppe/25322-bug-main-section-disappears-when-navigating…
ndelangen Jan 31, 2024
cdbfaf5
Merge branch 'next' into jeppe/25322-bug-main-section-disappears-when…
ndelangen Jan 31, 2024
002754f
change to focal
ndelangen Jan 31, 2024
c4a7d4c
Merge branch 'jeppe/25322-bug-main-section-disappears-when-navigating…
ndelangen Jan 31, 2024
dfa1f88
yolo
ndelangen Jan 31, 2024
62d5aac
...
ndelangen Jan 31, 2024
b6aa557
!!!
ndelangen Jan 31, 2024
658ce8f
???
ndelangen Jan 31, 2024
8b63181
,,,,
ndelangen Jan 31, 2024
b3ddedf
oooo
ndelangen Jan 31, 2024
d6df2a1
aaaaaa
ndelangen Jan 31, 2024
688682a
oof
ndelangen Jan 31, 2024
01647d0
Merge branch 'next' into jeppe/25322-bug-main-section-disappears-when…
ndelangen Jan 31, 2024
24e6213
Merge branch 'next' into jeppe/25322-bug-main-section-disappears-when…
ndelangen Jan 31, 2024
56470f2
move the migration notes
ndelangen Feb 1, 2024
fe286a8
Merge branch 'jeppe/25322-bug-main-section-disappears-when-navigating…
ndelangen Feb 1, 2024
3b950a7
Merge branch 'next' into jeppe/25322-bug-main-section-disappears-when…
ndelangen Feb 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove story, because it's not valuable, and the component now depend…
…s on the container component
ndelangen committed Jan 29, 2024
commit 73c9fd33a27d616d3a0dc19f42f49a887f262ed8
55 changes: 0 additions & 55 deletions code/ui/manager/src/components/preview/Preview.mockdata.tsx

This file was deleted.

169 changes: 0 additions & 169 deletions code/ui/manager/src/components/preview/Preview.stories.tsx

This file was deleted.

1 change: 0 additions & 1 deletion code/ui/manager/src/components/preview/Toolbar.tsx
Original file line number Diff line number Diff line change
@@ -171,7 +171,6 @@ export const ToolbarComp = React.memo<ToolData>(function ToolbarComp({
});

export const Tools = React.memo<{ list: Addon_BaseType[] }>(function Tools({ list }) {
console.log({ list });
return (
<>
{list.filter(Boolean).map(({ render: Render, id, ...t }, index) => (