Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix sidebar top and bottom addons not showing #25825

Merged
merged 3 commits into from
Jan 31, 2024
Merged

UI: Fix sidebar top and bottom addons not showing #25825

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbd3f18
fix memo
ndelangen Jan 30, 2024
c7e066b
Merge branch 'next' into norbert/fix-memo-in-ui
ndelangen Jan 31, 2024
5fb747d
Merge branch 'next' into norbert/fix-memo-in-ui
ndelangen Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/ui/manager/src/container/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ const Sidebar = React.memo(function Sideber({ onMenuClick }: SidebarProps) {
const bottomItems = api.getElements(Addon_TypesEnum.experimental_SIDEBAR_BOTTOM);
const topItems = api.getElements(Addon_TypesEnum.experimental_SIDEBAR_TOP);
// eslint-disable-next-line react-hooks/exhaustive-deps
const bottom = useMemo(() => Object.values(bottomItems), [...Object.values(bottomItems)]);
const bottom = useMemo(() => Object.values(bottomItems), [Object.keys(bottomItems).join('')]);
// eslint-disable-next-line react-hooks/exhaustive-deps
const top = useMemo(() => Object.values(topItems), [...Object.values(topItems)]);
const top = useMemo(() => Object.values(topItems), [Object.keys(topItems).join('')]);

return {
title: name,
Expand Down
Loading