Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.2.0-alpha.2 #27151

Merged
merged 41 commits into from
May 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
4cce677
fix: color control buggy
gitstart May 18, 2023
63a952b
Same name for related Radio
srapilly Jul 8, 2023
c47c267
Merge branch 'next' into group-radio-by-name
yannbf Nov 20, 2023
2d39ba4
Merge branch 'next' into fix/color-input-buggy
ndelangen Nov 28, 2023
a6252a2
chore: introduce `nissuer`
balazsorban44 Apr 22, 2024
9b66eec
move comments
balazsorban44 Apr 22, 2024
0245d8b
test(core-common): migrate to vitest test functions
43081j May 8, 2024
46e3617
Fix Typeset fontSizes type to match docs
noranda Mar 13, 2024
4496b48
Update type and fix docs
noranda May 8, 2024
640a84f
Misc docs updates
kylegach May 14, 2024
ecc734c
Add CT to portable stories playwright title
kylegach May 15, 2024
9454788
Fix failing stories
yannbf May 15, 2024
e80cb5a
fix another story
yannbf May 15, 2024
5a0bf20
disable chromatic turboSnap for storybook:ui
yannbf May 15, 2024
41c15fc
Merge pull request #27068 from 43081j/cc-test
JReinhold May 15, 2024
3e5fb46
Merge pull request #26475 from noranda/nb/fix-typeset-fontsizes-type
JReinhold May 15, 2024
879f979
Merge pull request #22615 from gitstart/fix/color-input-buggy
JReinhold May 15, 2024
42a1f32
Update CHANGELOG.md for v8.1.1 [skip ci]
JReinhold May 15, 2024
cca91fc
Angular: Consider style inject option
valentinpalkovic May 15, 2024
aea3797
Merge branch 'next' into group-radio-by-name
JReinhold May 15, 2024
9c93c4c
Merge pull request #23374 from srapilly/group-radio-by-name
JReinhold May 15, 2024
72664eb
Merge branch 'next' into yann/fix-failing-stories
yannbf May 15, 2024
3124c9d
Use existing repro field in template
vanessayuenn May 15, 2024
e1a7e34
don't use label management
vanessayuenn May 15, 2024
3fe2c16
tweak issue comments
vanessayuenn May 15, 2024
e8352d0
Update invalid-link.md
vanessayuenn May 15, 2024
4d378cc
Merge branch 'next' into vy/nissuer
yannbf May 15, 2024
db078a6
Merge pull request #27160 from storybookjs/vy/nissuer
vanessayuenn May 15, 2024
c72473b
Merge next
kylegach May 15, 2024
b85c91f
Add React 18 disclaimer
kylegach May 15, 2024
3974106
Merge pull request #27132 from storybookjs/misc-docs-updates
kylegach May 15, 2024
f96341e
attempt to get the preview page multiple times
JReinhold May 15, 2024
27fa22a
Merge pull request #27165 from storybookjs/jeppe/27059-bench-script-f…
JReinhold May 16, 2024
ba69532
Merge pull request #27145 from storybookjs/yann/fix-failing-stories
yannbf May 16, 2024
1b50ce3
tweak the bug report template
vanessayuenn May 17, 2024
a2bbf3e
Merge pull request #27108 from storybookjs/valentin/fix-angular-style…
valentinpalkovic May 17, 2024
88816f9
Merge branch 'next' into vy/nissuer
vanessayuenn May 17, 2024
d4d4603
Merge pull request #27184 from storybookjs/vy/nissuer
vanessayuenn May 17, 2024
ea71032
Angular: Cleanup types
valentinpalkovic May 17, 2024
3c1098c
Merge pull request #27189 from storybookjs/valentin/angular-cleanup-t…
valentinpalkovic May 17, 2024
0206f1a
Write changelog for 8.2.0-alpha.2 [skip ci]
storybook-bot May 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Bug report 🐞
description: >-
Something is broken and you have a reliable reproduction? Let us know here.
For questions, please use "Question" below.
For questions, please post in GitHub Discussion.
title: '[Bug]: '
labels:
- needs triage
Expand All @@ -14,16 +14,26 @@ body:
description: A clear and concise description of what the bug is
validations:
required: true
- type: textarea
id: reproduce
- type: input
id: repro-link
attributes:
label: To Reproduce
label: Reproduction link
description: >-
Due to the high volume of reports we receive, we can only prioritize bug reports that include a clear reproduction of the problem. Please use [storybook.new](https://storybook.new) to create one, and consult our [documentation](https://storybook.js.org/docs/react/contribute/how-to-reproduce) for guidance. Thank you for your understanding!
placeholder: >-
Please provide a link to your reproduction here. If creating a reproduction really isn't feasible, let us know and be sure to include as much detail as you can to help us understand the issue.
Please provide a link to a reproduction of the issue. We accept reproductions hosted on GitHub, CodeSandbox, and StackBlitz. Due to the high volume of reports, we prioritize those with clear reproductions. The easiest way to create a reproduction is to use [storybook.new](https://storybook.new). For detailed guidance, please refer to our [documentation](https://storybook.js.org/docs/react/contribute/how-to-reproduce).

Important: If the provided URL is invalid (e.g., 404 error or private repository), we may close the issue. Thank you for your understanding!
validations:
required: true
- type: textarea
id: repro-steps
attributes:
label: Reproduction steps
description: >-
Include the steps to reproduce the issue using the provided link. Additionally, provide a clear and concise description of what you expected to happen.
placeholder: >-
1. Go to above link
2. Click on '....'
3. ...
- type: textarea
id: system
attributes:
Expand Down
12 changes: 12 additions & 0 deletions .github/comments/good-first-issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
The issue was marked with the `good first issue` label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

To get started, read the [Contributing Guide](https://storybook.js.org/docs/contribute/how-to-contribute). When you are ready, open a PR and link back to this issue in the form of adding `Fixes #1234` to the PR description, where `1234` is the issue number. This will automatically close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please remember to add tests to confirm your code changes will fix the issue and we do not regress in the future.

If you have any questions, feel free to ask below or hop onto the [Storybook Discord](https://discord.gg/storybook) and ask in the #contributing channel. We're looking forward to your contribution! ✨

> [!NOTE]
> There is no need to ask to be assigned or for permission (e.g. "can I work on this?"). Please, go ahead if there is no linked PR. :slightly_smiling_face:
50 changes: 50 additions & 0 deletions .github/comments/invalid-link.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
We could not detect a valid reproduction link. **Make sure to follow the bug report template carefully.**

### Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a **public** GitHub repository, Stackblitz or CodeSandbox. The easiest way to create a reproduction is with [storybook.new](https://storybook.new).

The bug template that you filled out has a section called "To reproduce", which is where you should provide the link to the reproduction.

- If you did not provide a link or the link you provided is not valid, we will close the issue.
- If you provide a link to a private repository, we will close the issue.
- If you provide a link to a repository but not in the correct section, we will close the issue.

### What should I do?

Depending on the reason the issue was closed, you can do the following:

- If you did not provide a link, please open a new issue with a link to a reproduction.
- If you provided a link to a private repository, please open a new issue with a link to a public repository.
- If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

**In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.**

### My repository is private and cannot be public

In most cases, a private repo will not be a sufficient **minimal reproduction**, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do **not** make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

- Remove any code that is not related to the issue. (pages, API routes, irrelevant components, etc.)
- Remove any dependencies that are not related to the issue.
- Remove any third-party service that would require us to sign up for an account to reproduce the issue.
- Remove any environment variables that are not related to the issue.
- Remove private packages that we do not have access to.
- If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

### I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

### I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every Storybook issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

### Useful Resources

- [Create a Storybook reproduction](https://storybook.js.org/docs/react/contribute/how-to-reproduce)
- [How to create a Minimal, Complete, and Verifiable example](https://stackoverflow.com/help/mcve)
- [Contributing to Storybook](https://storybook.js.org/docs/contribute/how-to-contribute)
30 changes: 30 additions & 0 deletions .github/workflows/triage.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Triage issues

on:
issues:
types: [opened, labeled]
issue_comment:
types: [created]

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

permissions:
issues: write

jobs:
triage:
name: Nissuer
runs-on: ubuntu-latest
steps:
- uses: balazsorban44/[email protected]
with:
label-comments: |
{
"good first issue": ".github/comments/good-first-issue.md"
}
reproduction-comment: ".github/comments/invalid-link.md"
reproduction-hosts: "github.com,codesandbox.io,stackblitz.com"
reproduction-link-section: "### Reproduction link(.*)### Reproduction steps"
reproduction-invalid-label: "needs reproduction"
reproduction-issue-labels: "bug,needs triage"
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## 8.1.1

- Docgen: Only add react-docgen info when a component is defined in the file - [#26967](https://github.com/storybookjs/storybook/pull/26967), thanks @glenjamin!
- Docs: Fix MDX Stories block tag-filtering behavior - [#27144](https://github.com/storybookjs/storybook/pull/27144), thanks @shilman!
- Docs: Fix Subtitle block when no `of` prop passed - [#27147](https://github.com/storybookjs/storybook/pull/27147), thanks @JReinhold!
- Next.js: Add typing for NextImage to main framework options type - [#27105](https://github.com/storybookjs/storybook/pull/27105), thanks @valentinpalkovic!
- Next.js: Avoid conflicts with the raw loader - [#27093](https://github.com/storybookjs/storybook/pull/27093), thanks @seanparmelee!
- Types: Fix typing for main.framework/builder fields - [#27088](https://github.com/storybookjs/storybook/pull/27088), thanks @valentinpalkovic!

## 8.1.0

Storybook 8.1 is here with a tone of new features and bug fixes:
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.prerelease.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 8.2.0-alpha.2

- Angular: Cleanup types - [#27189](https://github.com/storybookjs/storybook/pull/27189), thanks @valentinpalkovic!
- Angular: Fix filtering of workspace config styles - [#27108](https://github.com/storybookjs/storybook/pull/27108), thanks @valentinpalkovic!
- Controls: Fix grouped Radio controls to have the same name - [#23374](https://github.com/storybookjs/storybook/pull/23374), thanks @srapilly!
- Controls: Throttling makes Color control lagging - [#22615](https://github.com/storybookjs/storybook/pull/22615), thanks @gitstart!
- Docs: Fix `Typeset` Doc block `fontSizes` type - [#26475](https://github.com/storybookjs/storybook/pull/26475), thanks @noranda!

## 8.2.0-alpha.1

- CLI: Add optional `--dev` and `--no-dev` options to `storybook init` CLI - [#26918](https://github.com/storybookjs/storybook/pull/26918), thanks @fastfrwrd!
Expand Down
6 changes: 3 additions & 3 deletions code/addons/docs/docs/docspage.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,9 @@ You can override this default behavior in `.storybook/preview.js` (or in any of
export const parameters = {
docs: {
canvas: {
sourceState: 'shown'
}
}
sourceState: 'shown',
},
},
};
```

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { dirname, join, resolve } from 'path';
import { DefinePlugin, HotModuleReplacementPlugin, ProgressPlugin, ProvidePlugin } from 'webpack';
import type { Configuration } from 'webpack';
import HtmlWebpackPlugin from 'html-webpack-plugin';

// @ts-expect-error (I removed this on purpose, because it's incorrect)
import CaseSensitivePathsPlugin from 'case-sensitive-paths-webpack-plugin';
import TerserWebpackPlugin from 'terser-webpack-plugin';
Expand Down Expand Up @@ -53,7 +54,11 @@ const storybookPaths: Record<string, string> = {
};

export default async (
options: Options & { typescriptOptions: TypescriptOptions }
options: Options & {
typescriptOptions: TypescriptOptions;
/* Build entries, which should not be linked in the iframe HTML file */
excludeChunks?: string[];
}
): Promise<Configuration> => {
const {
outputDir = join('.', 'public'),
Expand All @@ -64,6 +69,7 @@ export default async (
previewUrl,
typescriptOptions,
features,
excludeChunks = [],
} = options;

const isProd = configType === 'PRODUCTION';
Expand Down Expand Up @@ -172,6 +178,7 @@ export default async (
alwaysWriteToDisk: true,
inject: false,
template,
excludeChunks,
templateParameters: {
version: packageJson.version,
globals: {
Expand Down
Loading