Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-interactions: Fix using dates in expect statements #28413

Open
wants to merge 8 commits into
base: next-8.5
Choose a base branch
from
Open

Addon-interactions: Fix using dates in expect statements #28413

wants to merge 8 commits into from

Conversation

yann-combarnous
Copy link

@yann-combarnous yann-combarnous commented Jul 1, 2024 •
edited
Loading

Closes #24465

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

jadehamel
jadehamel reviewed Jul 1, 2024
View reviewed changes
code/addons/interactions/src/components/MethodCall.tsx Outdated
@@ -341,7 +341,7 @@ export const ElementNode = ({
};

export const DateNode = ({ value }: { value: string | Date }) => {
const [date, time, ms] = (value instanceof Date ? value.toISOString() : value).split(/[T.Z]/);
const [date, time, ms] = new Date(value).toISOString().split(/[T.Z]/);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change assumes value can always be converted to a valid Date. However, if value is an invalid date string, new Date(value) will result in an invalid Date object (Invalid Date).

It can lead to runtime errors if value is not a valid date string. Consider adding error handling for invalid dates.

Suggestion: To handle potential invalid date values, add error handling and validate the date conversion.

Something like this:

export const DateNode = ({ value }: { value: string | Date }) => {
  let dateStr, time, ms;

  try {
    const dateObj = new Date(value);
    if (isNaN(dateObj.getTime())) {
      throw new Error('Invalid date');
    }
    [dateStr, time, ms] = dateObj.toISOString().split(/[T.Z]/);
  } catch (error) {
    console.error('Invalid date value provided to DateNode:', value);
    [dateStr, time, ms] = ['Invalid date', '', ''];
  }

  const colors = useThemeColors();
  return (
    <span style={{ whiteSpace: 'nowrap', color: colors.date }}>
      {dateStr} {time} {ms}
    </span>
  );
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jadehamel , updated PR with catch for invalid date.

Copy link
Member

@ghengeveld ghengeveld Jul 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good suggestion. I think we can even make do without the try/catch by omitting the getTime call. I left a review with my take on it.

greptile-apps[bot]
greptile-apps bot reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added test case for date values in Args story in /code/addons/interactions/src/components/MethodCall.stories.tsx
  • Updated /code/addons/interactions/src/components/MethodCall.tsx to handle string and Date object types for date values
  • Implemented error handling for invalid Date objects in /code/addons/interactions/src/components/MethodCall.tsx
  • Conditional rendering of time and millisecond parts only if the date is valid in /code/addons/interactions/src/components/MethodCall.tsx

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

code/addons/interactions/src/components/MethodCall.tsx Outdated Show resolved Hide resolved
@shilman shilman changed the title fix: Using dates in expect statements with the interactions add-on causes Storybook to crash (#24465) Test: Fix using dates in expect statements with the interactions add-on Jul 15, 2024
@shilman shilman changed the title Test: Fix using dates in expect statements with the interactions add-on Addon-interactions: Fix using dates in expect statements Jul 15, 2024
ghengeveld
ghengeveld reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Date parsing and rendering is always a pain. I think it can be done a little cleaner so I made some suggestions.

code/addons/interactions/src/components/MethodCall.tsx Outdated Show resolved Hide resolved
code/addons/interactions/src/components/MethodCall.tsx Outdated Show resolved Hide resolved
@yann-combarnous
Copy link
Author

Thanks for picking this up. Date parsing and rendering is always a pain. I think it can be done a little cleaner so I made some suggestions.

Thx, PR updated

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 16, 2024
@bodograumann
Copy link
Contributor

Is that failing test due to this PR or can we merge?

@kurellajunior
Copy link

Bug’s still around, can we help merging it?

@valentinpalkovic valentinpalkovic changed the base branch from next to next-8.5 December 24, 2024 14:19
@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: b266da8, ran on 24 December 2024 at 14:29:03 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-a11y

Before After Difference
Dependency count 0 59 🚨 +59 🚨
Self size 0 B 410 KB 🚨 +410 KB 🚨
Dependency size 0 B 13.46 MB 🚨 +13.46 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-actions

Before After Difference
Dependency count 0 7 🚨 +7 🚨
Self size 0 B 59 KB 🚨 +59 KB 🚨
Dependency size 0 B 3.22 MB 🚨 +3.22 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-backgrounds

Before After Difference
Dependency count 0 4 🚨 +4 🚨
Self size 0 B 27 KB 🚨 +27 KB 🚨
Dependency size 0 B 99 KB 🚨 +99 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-controls

Before After Difference
Dependency count 0 3 🚨 +3 🚨
Self size 0 B 260 KB 🚨 +260 KB 🚨
Dependency size 0 B 47 KB 🚨 +47 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-docs

Before After Difference
Dependency count 0 17 🚨 +17 🚨
Self size 0 B 2.20 MB 🚨 +2.20 MB 🚨
Dependency size 0 B 7.88 MB 🚨 +7.88 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-essentials

Before After Difference
Dependency count 0 36 🚨 +36 🚨
Self size 0 B 17 KB 🚨 +17 KB 🚨
Dependency size 0 B 13.83 MB 🚨 +13.83 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-mdx-gfm

Before After Difference
Dependency count 0 69 🚨 +69 🚨
Self size 0 B 4 KB 🚨 +4 KB 🚨
Dependency size 0 B 2.41 MB 🚨 +2.41 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-highlight

Before After Difference
Dependency count 0 1 🚨 +1 🚨
Self size 0 B 9 KB 🚨 +9 KB 🚨
Dependency size 0 B 5 KB 🚨 +5 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-interactions

Before After Difference
Dependency count 0 56 🚨 +56 🚨
Self size 0 B 129 KB 🚨 +129 KB 🚨
Dependency size 0 B 12.73 MB 🚨 +12.73 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-jest

Before After Difference
Dependency count 0 4 🚨 +4 🚨
Self size 0 B 38 KB 🚨 +38 KB 🚨
Dependency size 0 B 84 KB 🚨 +84 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-links

Before After Difference
Dependency count 0 4 🚨 +4 🚨
Self size 0 B 19 KB 🚨 +19 KB 🚨
Dependency size 0 B 284 KB 🚨 +284 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-measure

Before After Difference
Dependency count 0 2 🚨 +2 🚨
Self size 0 B 32 KB 🚨 +32 KB 🚨
Dependency size 0 B 20 KB 🚨 +20 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-onboarding

Before After Difference
Dependency count 0 0 0
Self size 0 B 218 KB 🚨 +218 KB 🚨
Dependency size 0 B 664 B 🚨 +664 B 🚨
Bundle Size Analyzer Link Link

@storybook/addon-outline

Before After Difference
Dependency count 0 2 🚨 +2 🚨
Self size 0 B 23 KB 🚨 +23 KB 🚨
Dependency size 0 B 32 KB 🚨 +32 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-storysource

Before After Difference
Dependency count 0 7 🚨 +7 🚨
Self size 0 B 1.89 MB 🚨 +1.89 MB 🚨
Dependency size 0 B 10.70 MB 🚨 +10.70 MB 🚨
Bundle Size Analyzer Link Link

@storybook/experimental-addon-test

Before After Difference
Dependency count 0 60 🚨 +60 🚨
Self size 0 B 973 KB 🚨 +973 KB 🚨
Dependency size 0 B 14.15 MB 🚨 +14.15 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-themes

Before After Difference
Dependency count 0 1 🚨 +1 🚨
Self size 0 B 19 KB 🚨 +19 KB 🚨
Dependency size 0 B 28 KB 🚨 +28 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-toolbars

Before After Difference
Dependency count 0 0 0
Self size 0 B 10 KB 🚨 +10 KB 🚨
Dependency size 0 B 656 B 🚨 +656 B 🚨
Bundle Size Analyzer Link Link

@storybook/addon-viewport

Before After Difference
Dependency count 0 2 🚨 +2 🚨
Self size 0 B 27 KB 🚨 +27 KB 🚨
Dependency size 0 B 67 KB 🚨 +67 KB 🚨
Bundle Size Analyzer Link Link

@storybook/builder-vite

Before After Difference
Dependency count 0 6 🚨 +6 🚨
Self size 0 B 438 KB 🚨 +438 KB 🚨
Dependency size 0 B 831 KB 🚨 +831 KB 🚨
Bundle Size Analyzer Link Link

@storybook/builder-webpack5

Before After Difference
Dependency count 0 234 🚨 +234 🚨
Self size 0 B 80 KB 🚨 +80 KB 🚨
Dependency size 0 B 31.04 MB 🚨 +31.04 MB 🚨
Bundle Size Analyzer Link Link

@storybook/core

Before After Difference
Dependency count 0 50 🚨 +50 🚨
Self size 0 B 21.45 MB 🚨 +21.45 MB 🚨
Dependency size 0 B 14.37 MB 🚨 +14.37 MB 🚨
Bundle Size Analyzer Link Link

@storybook/builder-manager

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 701 B 🚨 +701 B 🚨
Bundle Size Analyzer Link Link

@storybook/channels

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 673 B 🚨 +673 B 🚨
Bundle Size Analyzer Link Link

@storybook/client-logger

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 693 B 🚨 +693 B 🚨
Bundle Size Analyzer Link Link

@storybook/components

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 681 B 🚨 +681 B 🚨
Bundle Size Analyzer Link Link

@storybook/core-common

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 685 B 🚨 +685 B 🚨
Bundle Size Analyzer Link Link

@storybook/core-events

Before After Difference
Dependency count 0 0 0
Self size 0 B 4 KB 🚨 +4 KB 🚨
Dependency size 0 B 685 B 🚨 +685 B 🚨
Bundle Size Analyzer Link Link

@storybook/core-server

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 685 B 🚨 +685 B 🚨
Bundle Size Analyzer Link Link

@storybook/csf-tools

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 677 B 🚨 +677 B 🚨
Bundle Size Analyzer Link Link

@storybook/docs-tools

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 681 B 🚨 +681 B 🚨
Bundle Size Analyzer Link Link

@storybook/manager

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 669 B 🚨 +669 B 🚨
Bundle Size Analyzer Link Link

@storybook/manager-api

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 685 B 🚨 +685 B 🚨
Bundle Size Analyzer Link Link

@storybook/node-logger

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 685 B 🚨 +685 B 🚨
Bundle Size Analyzer Link Link

@storybook/preview

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 669 B 🚨 +669 B 🚨
Bundle Size Analyzer Link Link

@storybook/preview-api

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 685 B 🚨 +685 B 🚨
Bundle Size Analyzer Link Link

@storybook/router

Before After Difference
Dependency count 0 0 0
Self size 0 B 2 KB 🚨 +2 KB 🚨
Dependency size 0 B 665 B 🚨 +665 B 🚨
Bundle Size Analyzer Link Link

@storybook/telemetry

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 677 B 🚨 +677 B 🚨
Bundle Size Analyzer Link Link

@storybook/theming

Before After Difference
Dependency count 0 0 0
Self size 0 B 2 KB 🚨 +2 KB 🚨
Dependency size 0 B 669 B 🚨 +669 B 🚨
Bundle Size Analyzer Link Link

@storybook/types

Before After Difference
Dependency count 0 0 0
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 661 B 🚨 +661 B 🚨
Bundle Size Analyzer Link Link

@storybook/angular

Before After Difference
Dependency count 0 261 🚨 +261 🚨
Self size 0 B 364 KB 🚨 +364 KB 🚨
Dependency size 0 B 33.56 MB 🚨 +33.56 MB 🚨
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 0 253 🚨 +253 🚨
Self size 0 B 22 KB 🚨 +22 KB 🚨
Dependency size 0 B 31.07 MB 🚨 +31.07 MB 🚨
Bundle Size Analyzer Link Link

@storybook/experimental-nextjs-vite

Before After Difference
Dependency count 0 153 🚨 +153 🚨
Self size 0 B 231 KB 🚨 +231 KB 🚨
Dependency size 0 B 44.70 MB 🚨 +44.70 MB 🚨
Bundle Size Analyzer Link Link

@storybook/html-vite

Before After Difference
Dependency count 0 15 🚨 +15 🚨
Self size 0 B 5 KB 🚨 +5 KB 🚨
Dependency size 0 B 1.91 MB 🚨 +1.91 MB 🚨
Bundle Size Analyzer Link Link

@storybook/html-webpack5

Before After Difference
Dependency count 0 244 🚨 +244 🚨
Self size 0 B 6 KB 🚨 +6 KB 🚨
Dependency size 0 B 31.59 MB 🚨 +31.59 MB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 0 589 🚨 +589 🚨
Self size 0 B 472 KB 🚨 +472 KB 🚨
Dependency size 0 B 83.28 MB 🚨 +83.28 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preact-vite

Before After Difference
Dependency count 0 13 🚨 +13 🚨
Self size 0 B 6 KB 🚨 +6 KB 🚨
Dependency size 0 B 1.31 MB 🚨 +1.31 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preact-webpack5

Before After Difference
Dependency count 0 242 🚨 +242 🚨
Self size 0 B 6 KB 🚨 +6 KB 🚨
Dependency size 0 B 31.16 MB 🚨 +31.16 MB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 0 105 🚨 +105 🚨
Self size 0 B 42 KB 🚨 +42 KB 🚨
Dependency size 0 B 18.03 MB 🚨 +18.03 MB 🚨
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 0 87 🚨 +87 🚨
Self size 0 B 13 KB 🚨 +13 KB 🚨
Dependency size 0 B 16.03 MB 🚨 +16.03 MB 🚨
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 0 320 🚨 +320 🚨
Self size 0 B 6 KB 🚨 +6 KB 🚨
Dependency size 0 B 42.34 MB 🚨 +42.34 MB 🚨
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 0 252 🚨 +252 🚨
Self size 0 B 14 KB 🚨 +14 KB 🚨
Dependency size 0 B 32.57 MB 🚨 +32.57 MB 🚨
Bundle Size Analyzer Link Link

@storybook/svelte-vite

Before After Difference
Dependency count 0 134 🚨 +134 🚨
Self size 0 B 22 KB 🚨 +22 KB 🚨
Dependency size 0 B 36.38 MB 🚨 +36.38 MB 🚨
Bundle Size Analyzer Link Link

@storybook/svelte-webpack5

Before After Difference
Dependency count 0 307 🚨 +307 🚨
Self size 0 B 6 KB 🚨 +6 KB 🚨
Dependency size 0 B 39.16 MB 🚨 +39.16 MB 🚨
Bundle Size Analyzer Link Link

@storybook/sveltekit

Before After Difference
Dependency count 0 142 🚨 +142 🚨
Self size 0 B 47 KB 🚨 +47 KB 🚨
Dependency size 0 B 39.68 MB 🚨 +39.68 MB 🚨
Bundle Size Analyzer Link Link

@storybook/vue3-vite

Before After Difference
Dependency count 0 107 🚨 +107 🚨
Self size 0 B 15 KB 🚨 +15 KB 🚨
Dependency size 0 B 42.52 MB 🚨 +42.52 MB 🚨
Bundle Size Analyzer Link Link

@storybook/vue3-webpack5

Before After Difference
Dependency count 0 493 🚨 +493 🚨
Self size 0 B 6 KB 🚨 +6 KB 🚨
Dependency size 0 B 55.56 MB 🚨 +55.56 MB 🚨
Bundle Size Analyzer Link Link

@storybook/web-components-vite

Before After Difference
Dependency count 0 16 🚨 +16 🚨
Self size 0 B 5 KB 🚨 +5 KB 🚨
Dependency size 0 B 1.94 MB 🚨 +1.94 MB 🚨
Bundle Size Analyzer Link Link

@storybook/web-components-webpack5

Before After Difference
Dependency count 0 242 🚨 +242 🚨
Self size 0 B 5 KB 🚨 +5 KB 🚨
Dependency size 0 B 31.21 MB 🚨 +31.21 MB 🚨
Bundle Size Analyzer Link Link

@storybook/blocks

Before After Difference
Dependency count 0 4 🚨 +4 🚨
Self size 0 B 604 KB 🚨 +604 KB 🚨
Dependency size 0 B 1.49 MB 🚨 +1.49 MB 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 0 51 🚨 +51 🚨
Self size 0 B 22 KB 🚨 +22 KB 🚨
Dependency size 0 B 35.81 MB 🚨 +35.81 MB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 0 52 🚨 +52 🚨
Self size 0 B 1 KB 🚨 +1 KB 🚨
Dependency size 0 B 35.84 MB 🚨 +35.84 MB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 0 393 🚨 +393 🚨
Self size 0 B 496 KB 🚨 +496 KB 🚨
Dependency size 0 B 77.68 MB 🚨 +77.68 MB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 0 273 🚨 +273 🚨
Self size 0 B 612 KB 🚨 +612 KB 🚨
Dependency size 0 B 67.58 MB 🚨 +67.58 MB 🚨
Bundle Size Analyzer Link Link

@storybook/core-webpack

Before After Difference
Dependency count 0 3 🚨 +3 🚨
Self size 0 B 16 KB 🚨 +16 KB 🚨
Dependency size 0 B 2.40 MB 🚨 +2.40 MB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 0 109 🚨 +109 🚨
Self size 0 B 1.11 MB 🚨 +1.11 MB 🚨
Dependency size 0 B 44.95 MB 🚨 +44.95 MB 🚨
Bundle Size Analyzer Link Link

@storybook/csf-plugin

Before After Difference
Dependency count 0 3 🚨 +3 🚨
Self size 0 B 10 KB 🚨 +10 KB 🚨
Dependency size 0 B 788 KB 🚨 +788 KB 🚨
Bundle Size Analyzer Link Link

@storybook/instrumenter

Before After Difference
Dependency count 0 5 🚨 +5 🚨
Self size 0 B 221 KB 🚨 +221 KB 🚨
Dependency size 0 B 278 KB 🚨 +278 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-dom-shim

Before After Difference
Dependency count 0 0 0
Self size 0 B 10 KB 🚨 +10 KB 🚨
Dependency size 0 B 792 B 🚨 +792 B 🚨
Bundle Size Analyzer Link Link

@storybook/source-loader

Before After Difference
Dependency count 0 5 🚨 +5 🚨
Self size 0 B 41 KB 🚨 +41 KB 🚨
Dependency size 0 B 10.64 MB 🚨 +10.64 MB 🚨
Bundle Size Analyzer Link Link

@storybook/test

Before After Difference
Dependency count 0 53 🚨 +53 🚨
Self size 0 B 1.82 MB 🚨 +1.82 MB 🚨
Dependency size 0 B 8.09 MB 🚨 +8.09 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-create-react-app

Before After Difference
Dependency count 0 68 🚨 +68 🚨
Self size 0 B 18 KB 🚨 +18 KB 🚨
Dependency size 0 B 6.03 MB 🚨 +6.03 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-html-webpack

Before After Difference
Dependency count 0 102 🚨 +102 🚨
Self size 0 B 4 KB 🚨 +4 KB 🚨
Dependency size 0 B 22.72 MB 🚨 +22.72 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-preact-webpack

Before After Difference
Dependency count 0 4 🚨 +4 🚨
Self size 0 B 5 KB 🚨 +5 KB 🚨
Dependency size 0 B 2.41 MB 🚨 +2.41 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-react-webpack

Before After Difference
Dependency count 0 191 🚨 +191 🚨
Self size 0 B 24 KB 🚨 +24 KB 🚨
Dependency size 0 B 33.48 MB 🚨 +33.48 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-server-webpack

Before After Difference
Dependency count 0 20 🚨 +20 🚨
Self size 0 B 10 KB 🚨 +10 KB 🚨
Dependency size 0 B 3.85 MB 🚨 +3.85 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-svelte-webpack

Before After Difference
Dependency count 0 103 🚨 +103 🚨
Self size 0 B 14 KB 🚨 +14 KB 🚨
Dependency size 0 B 12.76 MB 🚨 +12.76 MB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-vue3-webpack

Before After Difference
Dependency count 0 374 🚨 +374 🚨
Self size 0 B 9 KB 🚨 +9 KB 🚨
Dependency size 0 B 47.57 MB 🚨 +47.57 MB 🚨
Bundle Size Analyzer Link Link

@storybook/html

Before After Difference
Dependency count 0 6 🚨 +6 🚨
Self size 0 B 47 KB 🚨 +47 KB 🚨
Dependency size 0 B 40 KB 🚨 +40 KB 🚨
Bundle Size Analyzer Link Link

@storybook/preact

Before After Difference
Dependency count 0 6 🚨 +6 🚨
Self size 0 B 23 KB 🚨 +23 KB 🚨
Dependency size 0 B 40 KB 🚨 +40 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react

Before After Difference
Dependency count 0 6 🚨 +6 🚨
Self size 0 B 932 KB 🚨 +932 KB 🚨
Dependency size 0 B 24 KB 🚨 +24 KB 🚨
Bundle Size Analyzer Link Link

@storybook/server

Before After Difference
Dependency count 0 9 🚨 +9 🚨
Self size 0 B 13 KB 🚨 +13 KB 🚨
Dependency size 0 B 974 KB 🚨 +974 KB 🚨
Bundle Size Analyzer Link Link

@storybook/svelte

Before After Difference
Dependency count 0 106 🚨 +106 🚨
Self size 0 B 96 KB 🚨 +96 KB 🚨
Dependency size 0 B 10.59 MB 🚨 +10.59 MB 🚨
Bundle Size Analyzer Link Link

@storybook/vue3

Before After Difference
Dependency count 0 17 🚨 +17 🚨
Self size 0 B 86 KB 🚨 +86 KB 🚨
Dependency size 0 B 6.08 MB 🚨 +6.08 MB 🚨
Bundle Size Analyzer Link Link

@storybook/web-components

Before After Difference
Dependency count 0 7 🚨 +7 🚨
Self size 0 B 62 KB 🚨 +62 KB 🚨
Dependency size 0 B 55 KB 🚨 +55 KB 🚨
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@jadehamel jadehamel jadehamel left review comments

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees

@ghengeveld ghengeveld

@valentinpalkovic valentinpalkovic

Labels
addon: interactions bug ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Using dates in expect statements with the interactions add-on causes Storybook to crash
7 participants
@yann-combarnous @bodograumann @kurellajunior @ghengeveld @jadehamel @shilman @valentinpalkovic