Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Filter non-inputs from controls #30550

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

robertIsaac
Copy link

@robertIsaac robertIsaac commented Feb 15, 2025

Relates #16865

rebase #18880 on next branch

Greptile Summary

Adds a feature flag to filter non-input controls from Angular components in Storybook, providing a cleaner and more focused controls panel by showing only input properties.

  • Modified code/frameworks/angular/src/client/docs/compodoc.ts to add FEATURES.angularFilterNonInputControls flag
  • Updated extractArgTypesFromData to only include inputsClass when feature flag is enabled
  • Excluded propertiesClass, methodsClass, and outputsClass with active feature flag
  • Maintains backward compatibility by preserving full property extraction when flag is disabled

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -17,6 +18,8 @@ import {
Property,
} from './types';

const { FEATURES } = global;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a type annotation for FEATURES to ensure type safety

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants