Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing babel-preset-env dependency #5617

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Add missing babel-preset-env dependency #5617

merged 1 commit into from
Feb 16, 2019

Conversation

Hypnosphi
Copy link
Member

Issue: #5498 broke the apps that doesn't have a dependency on babel-preset-env. We didn't catch that issue on CI because we have babel-preset-env hoisted from @storybook/react-native and ember-cli

Note that both this and #5498 can be reverted, if telejson gets rid of safe-eval dependency, see storybookjs/telejson#4

@shilman shilman merged commit da82c51 into next Feb 16, 2019
@shilman shilman deleted the missing-preset branch February 16, 2019 15:52
@shilman shilman added this to the v5.0.0 milestone Feb 16, 2019
shilman added a commit that referenced this pull request Feb 16, 2019
Add missing babel-preset-env dependency
@Jessidhia
Copy link
Contributor

This was the babel 6 version of preset-env. Are you sure this is the right dependency?

@shilman
Copy link
Member

shilman commented Feb 18, 2019

@Jessidhia Sounds like we can get rid of it before the final release:

Note that both this and #5498 can be reverted, if telejson gets rid of safe-eval dependency, see storybooks/telejson#4

@Hypnosphi
Copy link
Member Author

Hypnosphi commented Feb 18, 2019

@Jessidhia it turned out that this particular package is compatible both with Babel 6 and 7 (at least it works). I was surprised as well.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack core patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants