Fix addon install command #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command copied to the clipboard was different from the one displayed. It erroneously used 'npx' instead of 'npm'. Now we use 'npm' consistently. In addition, we add the '-D' flag to add the addon to dev dependencies, which is what people usually want to do.
✅ Deploy Preview for storybook-addon-catalog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for storybook-frontpage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kkuegler is attempting to deploy a commit to the Storybook Team on Vercel. A member of the Team first needs to authorize it. |
cdedreuille
approved these changes
Sep 1, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @cdedreuille, thanks for accepting the PR! I just wanted to check in because you merged storybookjs:main into my repo, but not (yet) the other way around. Maybe that was an oversight. |
|
It seems Carles no longer works for Chromatic/on Storybook. @kylegach Could you potentially take over this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command copied to the clipboard was different from the one displayed. It erroneously used 'npx' instead of 'npm'. Now we use 'npm' consistently.
In addition, we add the '-D' flag to add the addon to dev dependencies, which is what people usually want to do.