Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README.md with added emojis and solved #375 by adding discord link #374

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Add README.md with added emojis and solved #375 by adding discord link #374

merged 5 commits into from
Feb 10, 2025

Conversation

irfand29
Copy link

@irfand29 irfand29 commented Jan 3, 2025 •
edited
Loading

Description

This PR updates the README file to reflect the latest changes and improvements. The modifications include:

  • Added an overview of Story Protocol.
  • Fixed some grammatical errors and formatting issues
  • Added Emojis on Headings

@irfand29 irfand29 changed the title Update README with improved grammar and details Update README with improved improved formatting and added emojis Jan 26, 2025
@irfand29 irfand29 changed the title Update README with improved improved formatting and added emojis Update README with improved formatting and added emojis Jan 26, 2025
@irfand29 irfand29 changed the title Update README with improved formatting and added emojis Add README.md with improved formatting and added emojis Jan 26, 2025
@irfand29
Copy link
Author

Hey @kingster-will @Spablob @LeoHChen
Please take a look . I added Emojis for ease . It will add value to the docs.

kingster-will
kingster-will reviewed Jan 26, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@irfand29 irfand29 changed the title Add README.md with improved formatting and added emojis Add README.md with added emojis and solved #375 by adding discord link Jan 26, 2025
@irfand29
Copy link
Author

Hey @kingster-will
Kindly take a look . Now its all done perfectly imo

what's your opinion?

thanks

@irfand29
Copy link
Author

@kingster-will

@irfand29
Copy link
Author

Hey @kingster-will
Please take a look

@irfand29
Copy link
Author

Hey @kingster-will
Please take a look

1 similar comment
@irfand29
Copy link
Author

Hey @kingster-will
Please take a look

@irfand29
Copy link
Author

Hello sir, @kingster-will
Please take a look

kingster-will
kingster-will requested changes Feb 1, 2025
View reviewed changes
Copy link

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict.

@irfand29
Copy link
Author

irfand29 commented Feb 3, 2025

Please resolve the conflict.

Resolved. Please take a look @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 3, 2025

Hello @kingster-will please take a look thanks

@irfand29
Copy link
Author

irfand29 commented Feb 3, 2025

Please take a look @kingster-will

1 similar comment
@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

Please take a look @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

Please take a look @kingster-will

sir

@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

Please take a look @kingster-will sir

1 similar comment
@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

Please take a look @kingster-will sir

@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

Hello sir, please take a look i am done @kingster-will , thanks.

@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

I was not online when you tagged me sir @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 4, 2025

please take a llok @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 5, 2025

Please take a look sir

@kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 5, 2025

please take a look sir @kingster-will @LeoHChen @Spablob
thanks

@irfand29
Copy link
Author

irfand29 commented Feb 6, 2025

hello sir,
pls take a look sir @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 8, 2025

kindly merge @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 8, 2025

kindly merge im done @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 8, 2025

take a lookj @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 8, 2025

hello @kingster-will , kindly take a look. i am done THANKS

@kingster-will
Copy link

Can not merge the PR, blocked by github rules that requires all commits to be signed.

@irfand29
Update README with improved grammar and details
7e0d715
@irfand29
Update README.md with improved formatting and added emojis
8215ad1 
To make it easier to read and more visually appealing. Emojis were added to important sections to help guide readers and make the documentation more user-friendly.
@irfand29
Add README.md with improved formatting and added emojis
5c2240f 
To make it more visually engaging and easier to navigate by adding emojis to the headings. This helps enhance readability and adds a fun, appealing touch to the documentation
@irfand29
Copy link
Author

irfand29 commented Feb 8, 2025

hello sir,
pls take a look sir @kingster-will

now all done , all signed commits now
please merge it @kingster-will

@irfand29
Update README.md with improved formatting and added emojis
1a8ec89 
Added emojis and added contact at the end of document with discord clickable link

By taking storyprotocol#375 I added Discord here .

It will be very useful and add value. thanks
@irfand29
Copy link
Author

irfand29 commented Feb 8, 2025

hello sir,
now all done , all signed commits now, no conflicts
please merge it @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 9, 2025

all commits are signed.
please merge @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 9, 2025

now all signed commits
kindly merge @kingster-will

@irfand29
Copy link
Author

irfand29 commented Feb 9, 2025

now all signed commits
kindly merge @kingster-will sir

@irfand29
Copy link
Author

irfand29 commented Feb 9, 2025

Can not merge the PR, blocked by github rules that requires all commits to be signed.

now all signed commits
kindly merge @kingster-will

@irfand29
Copy link
Author

now all signed commits
kindly merge @kingster-will sir

@irfand29
Copy link
Author

Can not merge the PR, blocked by github rules that requires all commits to be signed.

now all signed commits
kindly merge @kingster-will

@kingster-will kingster-will merged commit b0336c2 into storyprotocol:main Feb 10, 2025
10 checks passed
This was referenced Feb 10, 2025
Closed
Closed
@irfand29
Copy link
Author

Thanks @kingster-will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spablob Spablob Awaiting requested review from Spablob Spablob is a code owner

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@kingster-will kingster-will Awaiting requested review from kingster-will kingster-will is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfand29 @kingster-will