Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK according to PoC Periphery Supported Workflows #292

Merged
merged 24 commits into from
Oct 19, 2024
Merged

Update SDK according to PoC Periphery Supported Workflows #292

merged 24 commits into from
Oct 19, 2024

Conversation

bonnie57
Copy link
Collaborator

@bonnie57 bonnie57 commented Oct 17, 2024 •
edited
Loading

Description

Align: PoC Periphery Supported Workflows

  1. Registration Workflows
  • createCollection
  • registerIp
  • mintAndRegisterIp
  1. License Attachment Workflows

  • registerPILTermsAndAttach

  • registerIpAndAttachPILTerms

  • mintAndRegisterIpAndAttachPILTerms

  1. Derivative Workflows

  • registerIpAndMakeDerivative

  • mintAndRegisterIpAndMakeDerivative

  • registerIpAndMakeDerivativeWithLicenseTokens

  • mintAndRegisterIpAndMakeDerivativeWithLicenseTokens

  1. Grouping Workflows

  • mintAndRegisterIpAndAttachLicenseAndAddToGroup

  • registerIpAndAttachLicenseAndAddToGroup

  • registerGroupAndAttachLicense

  • registerGroupAndAttachLicenseAndAddIps

  1. Royalty Workflows

  • transferToVaultAndSnapshotAndClaimByTokenBatch

  • transferToVaultAndSnapshotAndClaimBySnapshotBatch

  • snapshotAndClaimByTokenBatch

  • snapshotAndClaimBySnapshotBatch

Add other methods

  • registerGroup

Update methods

  • raiseDispute
  • claimRevenue

Remove methods

  • collectRoyaltyTokens

Test Plan

image image

Next steps

  • Add util methods from Tiage (Because of ipfs, so I skip dispute integration tests)
  • Add Odyssey chain

@bonnie57
Remove collectRoyaltyTokens methods and Update getRoyaltyVaultAddress…
1f55307 
… method
@bonnie57
Update createNFTCollection params
fe98761
@bonnie57
Update contract addresses
07edc67
@bonnie57
Update unit and integration tests
59baaf4
@bonnie57
Add mintAndRegisterIp method in ipAsset
a67f058
@bonnie57
Refactor validate license terms
969c328
@bonnie57
Add registerPilTermsAndAttach method in ipAsset
1a1e05f
@bonnie57
Adjust related methods referencing address
57f9559
@bonnie57
Add todo hint
b811e91
@bonnie57
Add registerIpAndMakeDerivativeWithLicenseTokens method in IpAsset mo…
02189ac 
…dule
@bonnie57
Add transferToVaultAndSnapshotAndClaimByTokenBatch method
a437d4f
@bonnie57
Add royalty related workflow methods
78e49da
@bonnie57
Solve ERC721 error
207b055
@bonnie57
Add group workflow relate methods
b0b5379
@bonnie57
Update new contract address
454298f
@bonnie57
Add debugger log
3f4dfe2
@bonnie57
Add registerGroupAndAttachLicenseAndAddIps unit tests
2d805c2
@bonnie57
Solve invalid signature and royalty error
2b02d23
@bonnie57
Add the related methods unit tests
bbe6732
allenchuang
allenchuang approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@allenchuang allenchuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonnie57 bonnie57 merged commit 0bd3de2 into dev Oct 19, 2024
6 checks passed
@bonnie57 bonnie57 deleted the bonnie/SDK-8 branch October 19, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenchuang allenchuang allenchuang approved these changes

@DonFungible DonFungible Awaiting requested review from DonFungible DonFungible is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonnie57 @allenchuang