New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update variable name from WALLET_PRIVATE_KEY to PRIVATE_KEY in README.md #384

Open

leopardracer wants to merge 1 commit into storyprotocol:dev from leopardracer:dev

leopardracer commented Jan 18, 2025

This PR updates the variable name in the wallet setup example code for consistency:

Changed variable name from WALLET_PRIVATE_KEY to PRIVATE_KEY in privateKeyToAccount call
Makes the code example more consistent by using the same variable name throughout
Improves code readability and prevents potential confusion


          Update README.md

90732f2

leopardracer requested review from LeoHChen, DonFungible, edisonz0718, jacob-tucker, AndyBoWu and allenchuang as code owners

January 18, 2025 16:50

leopardracer requested a deployment to external

January 18, 2025 16:50

— with

GitHub Actions Waiting

Author

leopardracer commented Jan 20, 2025

@LeoHChen @DonFungible @edisonz0718 @jacob-tucker @AndyBoWu @allenchuang I’ve just submitted a pull request. Could you please review it when you have a chance? I’d appreciate your feedback and any comments. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

DonFungible Awaiting requested review from DonFungible DonFungible is a code owner

edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

allenchuang Awaiting requested review from allenchuang allenchuang is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet