[WIP] Redesign with registerPILTerms methods #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonnie57
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker,
AndyBoWu and
allenchuang
as code owners
bonnie57
force-pushed
the
bonnie/SDK-44
branch
from
c729e57 to
32c5f5b
Compare
DracoLi
reviewed
Jan 23, 2025
| import { getAddress } from "../utils/utils"; | ||
| import { getRevenueShare } from "../utils/licenseTermsHelper"; | ||
|
|
||
| export class PILFlavor { |
There was a problem hiding this comment.
lets simplify the names, commercialUse, nonCommercial, commercialRemix, nonCommercialRemix. I don't think we need the PIL at the end. PILFlavor class already indicates that.
DracoLi
reviewed
Jan 23, 2025
| export type RegisterPILTermsRequest<PILType extends PIL_TYPE> = { | ||
| /** The license terms to be registered. */ | ||
| terms: | ||
| | (PILType extends PIL_TYPE.COMMERCIAL_USE ? CommercialLicenseTerms : never) |
There was a problem hiding this comment.
I suggest we simplify this usage. For terms here, the type can just be PILTermsInput, which is the same as RegisterPILTermsRequest from before. PilFlavor.xxx returns PILTerms, which should be compatible with PILTermsInput as PILTermsInput is just PILTerms but with some attributes that is now required.
We don't need to allow the user to provide an enum to use a preset.
terms: PILFlavor.commercialUse({
royaltyPolicy: zeroAddress,
defaultMintingFee: 10n,
commercialRevCeiling: 100,
}),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example:
This pr adds user login function, includes：
Test Plan
Example:
Related Issue
Redesign: license registerPILTerms #385
Notes