Skip to content

refactor: Disallow similar tool names in the tool registry #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

zastrowm
Copy link
Member

@zastrowm zastrowm commented Jun 9, 2025

Description

Follow-up to #178, where we discussed preventing similar_tool and similar-tool from both being added to the tool registry, to avoid ambiguity in direct-method invocations.

This removes the need for direct-method invocations from checking for similar names, thus that code was removed

Related Issues

#178, #139

Documentation PR

N/A

Type of Change

  • Other (please describe): Refactor

Testing

[How have you tested the change?]

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Per follow-up to strands-agents#178, where we discussed preventing similar_tool and similar-tool from both being added to the tool registry, to avoid ambiguity in direct-method invocations
@zastrowm zastrowm force-pushed the disallow_similar_tool_names branch from cb9badd to ba55e5f Compare June 11, 2025 19:57
@zastrowm zastrowm force-pushed the disallow_similar_tool_names branch from 882b902 to f9aec4b Compare June 11, 2025 20:05
@zastrowm zastrowm merged commit 264f511 into strands-agents:main Jun 11, 2025
10 checks passed
@zastrowm zastrowm self-assigned this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants