Skip to content

Commit

Permalink
fix: fixed GitHub icons in dark mode (#142)
Browse files Browse the repository at this point in the history
  • Loading branch information
COil authored Dec 21, 2024
1 parent 7f37fdf commit aa67da3
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
1 change: 0 additions & 1 deletion assets/icons/github.svg

This file was deleted.

7 changes: 6 additions & 1 deletion assets/styles/app.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* Pico ————————————————————————————————————————————————————————————————————— */

/**
* Reduce default size.
*
Expand All @@ -7,6 +9,8 @@
--pico-font-size: 100%; /* default size is 131.25% */
}

/* Layout ——————————————————————————————————————————————————————————————————— */

/**
* No text decoration for the header brand link.
*/
Expand All @@ -27,7 +31,7 @@ footer div.github {
text-align: right;
}

/* Symfony --------- */
/* Symfony —————————————————————————————————————————————————————————————————— */

/**
* Mark required fields in Symfony forms.
Expand All @@ -45,3 +49,4 @@ label.required:after {
form > div > div > ul > li {
color: red;
}

6 changes: 4 additions & 2 deletions templates/base.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
{% endblock %}
</head>

{% set gitHubSvgIcon = '<svg class="github-icon" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M12 0c-6.626 0-12 5.373-12 12 0 5.302 3.438 9.8 8.207 11.387.599.111.793-.261.793-.577v-2.234c-3.338.726-4.033-1.416-4.033-1.416-.546-1.387-1.333-1.756-1.333-1.756-1.089-.745.083-.729.083-.729 1.205.084 1.839 1.237 1.839 1.237 1.07 1.834 2.807 1.304 3.492.997.107-.775.418-1.305.762-1.604-2.665-.305-5.467-1.334-5.467-5.931 0-1.311.469-2.381 1.236-3.221-.124-.303-.535-1.524.117-3.176 0 0 1.008-.322 3.301 1.23.957-.266 1.983-.399 3.003-.404 1.02.005 2.047.138 3.006.404 2.291-1.552 3.297-1.23 3.297-1.23.653 1.653.242 2.874.118 3.176.77.84 1.235 1.911 1.235 3.221 0 4.609-2.807 5.624-5.479 5.921.43.372.823 1.102.823 2.222v3.293c0 .319.192.694.801.576 4.765-1.589 8.199-6.086 8.199-11.386 0-6.627-5.373-12-12-12z"/></svg>' %}

<body>

<header class="container" {{ stimulus_controller('header') }}>
Expand Down Expand Up @@ -54,7 +56,7 @@
</details>
</li>
<li>
<a class="contrast" data-tooltip="{{ website }}" data-placement="bottom" href="{{ website }}" target="_blank"><img alt="GitHub" class="github-icon" src="{{ asset('icons/github.svg') }}" width="24" height="24"></a>
<a class="contrast" data-tooltip="{{ website }}" data-placement="bottom" href="{{ website }}" target="_blank">{{ gitHubSvgIcon|raw }}</a>
</li>
<li>
<a class="theme-icon" {{ stimulus_target('header', 'lightEmoji') }} {{ stimulus_action('header', 'setDarkMode', 'click') }} data-tooltip="Switch to dark mode" data-placement="bottom">🔆</a>
Expand Down Expand Up @@ -87,7 +89,7 @@
</div>

<div class="github">
<a data-tooltip="{{ website }}" href="{{ website }}" target="_blank"><img alt="GitHub" class="github-icon" src="{{ asset('icons/github.svg') }}" width="24" height="24"></a>
<a class="contrast" data-tooltip="{{ website }}" data-placement="top" href="{{ website }}" target="_blank">{{ gitHubSvgIcon|raw }}</a>
</div>
</div>
</footer>
Expand Down

0 comments on commit aa67da3

Please sign in to comment.