fix: Don't require VolumeSnapshot CRDs to run the manager #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agouin This may help in testing colo. This way, you don't have to worry about supporting VolumeSnapshots to use CosmosFullNode resource. Use image ghcr.io/strangelove-ventures/cosmos-operator:dev28db602 |
danbryan
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #326
Without VolumeSnapshot CRDs, the entire operator process crashes.
Since VolumeSnapshots for supporting controllers (not for CosmosFullNode), I don't think crashing is appropriate. Instead it will run and report errors in appropriate places.