feat(CosmosFullNode): Allow configuring the chain home directory #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNix
changed the title
danbryan
approved these changes
Aug 29, 2023
|
FYI, I did extensive testing on a testnet cluster and it looked good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341
There's been too many instances where chains still persist data outside of the
--homeflag.Notably: Osmosis, DYDX, and now DVPN/Sentinel.
So we can't rely on chains to respect the user's intentions.
This feature allows the user to optionally configure the chain home.
Unfortunately, we can't reliably derive the home path because no chains use a common convention.