Add image override #355
Merged
Add image override #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNix
suggested changes
Sep 18, 2023
DavidNix
reviewed
Sep 19, 2023
| @@ -0,0 +1,22 @@ | |||
| name: Kube Manifests | |||
internal/fullnode/build_pods.go
Outdated
Comment on lines
32
to
34
| if o.Image != "" { | ||
| pod.Spec.Containers[0].Image = o.Image | ||
| } |
There was a problem hiding this comment.
Using the first image in the slice is the natural logic.
But I've gotten in trouble with this in the past. The user is able to patch and add whatever containers they want. This possibility is a tradeoff of the operator's flexibility. Therefore, if the user patches, there is no guarantee the node container will be the first one. So, I suggest finding the specific node container vs. using the slice index.
I'll push a commit tomorrow morning.
DavidNix
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to override the image for a specific pod, useful if pods are at different sync heights during initial sync.