feat: sets node type label #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntiTyping
commented
Sep 18, 2023
AntiTyping
force-pushed
the
feat_set_node_type
branch
from
5504d35
to
006aa68
Compare
DavidNix
reviewed
Sep 18, 2023
DavidNix
suggested changes
Sep 18, 2023
AntiTyping
force-pushed
the
feat_set_node_type
branch
from
006aa68
to
1f6d37c
Compare
|
@DavidNix I added test for all public API that uses labels |
* default type is FullNode * allowed values are FullNode|Sentry
AntiTyping
force-pushed
the
feat_set_node_type
branch
from
1f6d37c
to
6b7831b
Compare
DavidNix
approved these changes
Sep 19, 2023
AntiTyping
force-pushed
the
feat_set_node_type
branch
from
dc4290d
to
1bec2e9
Compare
DavidNix
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.