Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVC auto scale on a per ordinal basis #380

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Oct 27, 2023

Main motivation:

  • minimize created PVC size and expand only as needed on a per-PVC basis. Previously, it was always creating new PVCs with the latest auto scaled size, which meant that PVCs could not shrink on re-creation without re-creating the entire CosmosFullNode resource.
  • Allow autoDataSource to work with snapshots that are node-local

Changes:

  • New PVCs will not use the status.selfHealing size, but rather the maximum of: { spec.volumeClaimTemplate.resources.storage, spec.instanceOverrides[instanceName].volumeClaimTemplate.resources.storage, or data source size, if a data source is configured either explicitly or via autoDataSource }
  • status.selfHealing is now maintained on a per-instance basis, so that storage expansion is minimized. Pods can have different storage sizes based on their needs.
  • Allow autoDataSource to work with snapshots for same instance only with additional matchInstance: true

@agouin agouin marked this pull request as ready for review October 27, 2023 15:56
@agouin agouin merged commit 41a210e into main Oct 27, 2023
4 checks passed
@agouin agouin deleted the andrew/pvc_auto_scale_per_instance branch October 27, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants