Split err and status checks to avoid a null dereference error

strangelove-ventures · Jul 27, 2023 · 88262a5 · 88262a5
1 parent 4575a7a
commit 88262a5
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cmd/queue.go b/cmd/queue.go
@@ -44,8 +44,11 @@ func mostRecentReleasesForChain(
 	}
 
 	res, err := client.Do(req)
-	if err != nil || res.StatusCode != http.StatusOK {
-		return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("error performing github releases request: %v:%v", res.StatusCode, err)
+	if err != nil {
+		return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("error performing github releases request: %v", err)
+	}
+	if res.StatusCode != http.StatusOK {
+		return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("status code: %v", res.StatusCode)
 	}
 
 	defer res.Body.Close()