Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 3.2.2 #231

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Conversation

nitronit
Copy link
Contributor

@nitronit nitronit commented Dec 5, 2023

Minimum refactor start. As requested by @agouin =)

Moved the following to a new folder types:
Block type to a new file block.go
hrs.go
serialization.go
sign_state.go

@nitronit
Copy link
Contributor Author

nitronit commented Dec 19, 2023

@agouin

Walkthrough

The codebase has undergone a significant refactor, primarily involving changes to package names and structures, aiming for better clarity and organization. The signer package has been split into more descriptive packages like config, nodes, connector, and metrics. This restructuring affects imports, type references, and function calls across various files, indicating a broad enhancement of the project's modularity and possibly its functionality.

Changes

File Pattern Change Summary
.golangci.yml Added import alias cconfig for github.com/strangelove-ventures/horcrux/pkg/config.
cmd/horcrux/cmd/... New import statements; replaced signer with cconfig, thresholdTemP, nodesecurity; updated function calls and types.
pkg/config/... Package renamed from signer to config; default values and usage updates.
pkg/connector/... Package renamed from signer to connector; new Connector type; function calls now use metrics.
pkg/metrics/metrics.go Package renamed from "signer" to "metrics"; variable and method renaming.
pkg/nodes/... Package rename from "signer" to "nodes" or "nodes_test"; updates to function signatures, structs, configurations, and metrics handling.
pkg/thresholdTemP/... Package name changed from signer to thresholdTemP; additional imports; method and parameter type changes.
pkg/types/... New functions added; existing methods modified for clarity and functionality.
signer/... Various files updated with nodes package imports; references updated to match new package structures and types.
test/... Imports and references updated to new package names like config, thresholdTemP, and nodesecurity; type and function call updates.

…k.go, and use block.ToHRST() in threshold_validator.go
Update package tss to use Ed25519Key instead of CosignerEd25519Key

Update package config to include default values for nouncecahce

Update package types to fix comment formatting

Update package signer to use Ed25519Key instead of CosignerEd25519Key

Update package cosigner to fix typo in comments and add MPC struct

Update test files to use Ed25519Key instead of CosignerEd25519Key

Update cmd files to use CreatePersistentEd25519ThresholdSignShardsFromFile instead of CreateEd25519ThresholdSignShardsFromFile

Update test files to use Ed25519Key instead of CosignerEd25519Key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant