fix: Errors in cosmos Broadcaster are sometimes not propagated to cal…

…ler (#938)

(cherry picked from commit 1ac6f84)

# Conflicts:
#	go.work.sum

chain/cosmos/broadcaster.go

@@ -141,6 +141,15 @@ func (b *Broadcaster) UnmarshalTxResponseBytes(ctx context.Context, bytes []byte
 	if err := b.chain.cfg.EncodingConfig.Codec.UnmarshalJSON(bytes, &resp); err != nil {
 		return sdk.TxResponse{}, err
 	}
+
+	// persist nested errors such as ValidateBasic checks.
+	code := resp.Code
+	rawLog := resp.RawLog
+
+	if code != 0 {
+		return resp, fmt.Errorf("error in transaction (code: %d): raw_log: %s", code, rawLog)
+	}
+
 	return resp, nil
 }
 

examples/cosmos/chain_miscellaneous_test.go

@@ -315,6 +315,17 @@ func testBroadcaster(ctx context.Context, t *testing.T, chain *cosmos.CosmosChai
 	updatedBal2, err := chain.GetBalance(ctx, addr2, chain.Config().Denom)
 	require.NoError(t, err)
 	require.Equal(t, math.NewInt(2), updatedBal2)
+
+	txResp, err = cosmos.BroadcastTx(
+		ctx,
+		b,
+		users[0],
+		banktypes.NewMsgMultiSend(banktypes.Input{
+			Address: addr1,
+			Coins:   c1.Add(c2[0]),
+		}, out),
+	)
+	require.Error(t, err)
 }
 
 func testQueryCmd(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain) {