feat: replace broadcaster's account retriever to use chain's bech32 prefix when converting AccAddress to string #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refix when converting AccAddress to string
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Also, I'll appreciate the backport to v7. Let me know if I have to do something about it (I think some files may need a little bit of modification for v7) |
Reecepbcups
approved these changes
Mar 7, 2024
|
@madrezaz The latest main needs to be merged in then this is good to go :) |
Reecepbcups
pushed a commit
that referenced
this pull request
Mar 11, 2024
…use chain's bech32 prefix when converting AccAddress to string (#1010) * feat: replace broadcaster's account retriever to use chain's bech32 prefix when converting AccAddress to string (#1009) * feat: replace broadcaster's account retriever to use chain's bech32 prefix when converting AccAddress to string * refactor: enhance AccountRetriever (cherry picked from commit 1d1b837) # Conflicts: # chain/cosmos/broadcaster.go * fix: resolve conflicts (#1016) --------- Co-authored-by: MadReza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1008
This PR adds a custom implementation of the
AccountRetriever(copied from auth module) which is modified to convert anAccAddressto string using the target chain's bech32 prefix.