feat(v7)!: validators can have different genesis and self-delegation amounts #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I'll port this to |
Reecepbcups
reviewed
Mar 25, 2024
this is done by making ModifyGenesisAmounts take in an index parameter; the returned values will be used for the validator at that index.
fastfadingviolets
force-pushed
the
feat/stake-per-validator
branch
from
bb7658f
to
6dd5e90
Compare
Reecepbcups
changed the title
Reecepbcups
approved these changes
Mar 30, 2024
|
@Mergifyio backport main |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2024
…amounts (#1028) * feat validators can have different genesis and self-delegation amounts this is done by making ModifyGenesisAmounts take in an index parameter; the returned values will be used for the validator at that index. * Add a test for stake distribution in cosmos chains (cherry picked from commit 2908114)
|
Thanks for your work on this! super appreciated :) |
Reecepbcups
added a commit
that referenced
this pull request
Mar 30, 2024
…amounts (backport #1028) (#1039) * feat(v7)!: validators can have different genesis and self-delegation amounts (#1028) * feat validators can have different genesis and self-delegation amounts this is done by making ModifyGenesisAmounts take in an index parameter; the returned values will be used for the validator at that index. * Add a test for stake distribution in cosmos chains (cherry picked from commit 2908114) * fix v7 -> v8 namespace --------- Co-authored-by: violet <[email protected]> Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1027
Summary
Some issues only arise when there's an unequal distribution of stake among validators. This PR allows interchaintest to create chains whose validators have different stake. It does this by changing the
ModifyGenesisAmountsfunction in the chain config so that it takes in an index; the returned values will be used as the genesis and self-delegation amounts for the validator at that specific index.