Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!(v7): use default dependencies #1043

Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 2, 2024

For a long time, the v7 version of interchain test has used:

  • a retracted version of wasmd
  • a version of cometbft that is quite behind the times
  • a version of comsos-sdk that lacks a number of security patches

This PR resolves that set of problems, caused by a cluster of replace statements. It may have a single remaining issue remaining related to gogoproto, so I'm submitting this as a draft until that is resolved.

The biggest issue that this PR addresses is compatibility with the newer versions of standard cosmos software.

Note, this PR uses a "faddat" fork of go-substrate-rpc -- I can make a PR to misko9's repository, if that is preferred.

@faddat faddat requested a review from a team as a code owner April 2, 2024 13:02
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 3:30am

@faddat faddat marked this pull request as draft April 2, 2024 13:06
@faddat
Copy link
Contributor Author

faddat commented Apr 2, 2024

We'll need to bring in one replace:

@faddat
Copy link
Contributor Author

faddat commented Apr 2, 2024

Hopefully better?

ComposableFi/go-substrate-rpc-client#28

@faddat faddat changed the title use default dependencies throughout fix: use default dependencies throughout v7 Apr 2, 2024
@faddat faddat marked this pull request as ready for review April 2, 2024 16:08
@faddat faddat changed the title fix: use default dependencies throughout v7 fix: use default dependencies in v7 Apr 2, 2024
@faddat
Copy link
Contributor Author

faddat commented Apr 2, 2024

I'm not sure if test-cosmos examples is failing due to flakiness or another reason. Could you please let me know?

@faddat
Copy link
Contributor Author

faddat commented Apr 2, 2024

I'll revert the superfluous commit, just want to determine if we've got a flakiness issue or a test failure.

relayerfactory.go Outdated Show resolved Hide resolved
relayer/hyperspace/hyperspace_relayer.go Outdated Show resolved Hide resolved
chain/polkadot/keys.go Show resolved Hide resolved
local-interchain/go.mod Show resolved Hide resolved
@Reecepbcups Reecepbcups changed the title fix: use default dependencies in v7 deps!(v7): use default dependencies Apr 3, 2024
@faddat
Copy link
Contributor Author

faddat commented Apr 10, 2024

Ok i'll resolve the conflicts here.

@Reecepbcups Reecepbcups merged commit a60a72d into strangelove-ventures:v7 Apr 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants