-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps!(v7): use default dependencies #1043
Merged
Reecepbcups
merged 11 commits into
strangelove-ventures:v7
from
faddat:faddat/resolve-v7-dependency-issues
Apr 23, 2024
Merged
deps!(v7): use default dependencies #1043
Reecepbcups
merged 11 commits into
strangelove-ventures:v7
from
faddat:faddat/resolve-v7-dependency-issues
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
We'll need to bring in one replace: |
Hopefully better? |
faddat
changed the title
use default dependencies throughout
fix: use default dependencies throughout v7
Apr 2, 2024
faddat
changed the title
fix: use default dependencies throughout v7
fix: use default dependencies in v7
Apr 2, 2024
I'm not sure if test-cosmos examples is failing due to flakiness or another reason. Could you please let me know? |
I'll revert the superfluous commit, just want to determine if we've got a flakiness issue or a test failure. |
Reecepbcups
reviewed
Apr 3, 2024
Reecepbcups
changed the title
fix: use default dependencies in v7
deps!(v7): use default dependencies
Apr 3, 2024
Ok i'll resolve the conflicts here. |
Reecepbcups
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, the v7 version of interchain test has used:
This PR resolves that set of problems, caused by a cluster of replace statements. It may have a single remaining issue remaining related to gogoproto, so I'm submitting this as a draft until that is resolved.
The biggest issue that this PR addresses is compatibility with the newer versions of standard cosmos software.
Note, this PR uses a "faddat" fork of go-substrate-rpc -- I can make a PR to misko9's repository, if that is preferred.