refactor: remove blocksdb #1257
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| @@ -427,82 +423,6 @@ func (tn *ChainNode) Height(ctx context.Context) (int64, error) { | |||
| return height, nil | |||
| } | |||
|
|
|||
| // FindTxs implements blockdb.BlockSaver. | |||
| func (tn *ChainNode) FindTxs(ctx context.Context, height int64) ([]blockdb.Tx, error) { | |||
There was a problem hiding this comment.
refactor this to query cometbft for a given block, get the Txs, base64 decode, and query each tx hash from consensus directly to get the EventAttributes. Then query the block to get the FinalizeBlockEvents.
While this is less efficient, it removes a TON of code for a function that does not seem to be called hardly ever
| @@ -404,82 +400,6 @@ func (tn *ChainNode) Height(ctx context.Context) (int64, error) { | |||
| return height, nil | |||
| } | |||
|
|
|||
| // FindTxs implements blockdb.BlockSaver. | |||
| func (tn *ChainNode) FindTxs(ctx context.Context, height int64) ([]blockdb.Tx, error) { | |||
There was a problem hiding this comment.
Thorchain, ref chain_node: https://github.com/strangelove-ventures/interchaintest/pull/1257/files#r1759640964
|
The blocks db was instrumental in development of relayer v2, packet forward middleware async acks, and more. It is a lightweight indexer and easily allows you to inspect transaction lifecycle on involved chains. There is also the terminal UI built on top of it for browsing the indexed data. The usage is much more for developers to see sequence of events of blocks, transactions, and events, rather than any programmatic usage. |
Summary
This is a test PR to see if we can / should remove this.
Source graph shows we only used it internally. Only 2 issues have ever been posted about it, of which only 1 was external (Bearachain) from 2022. They are not even Cosmos anymore so their usecase is out. Any PRs are from 2022 during the initial creation
Further, we purposely do not use this feature as it causes CI failures due to some sqlite locks / non deterministic test behavior (was a big change I focused on in the v7->v8 migration).
Benfits
TODO: