Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific test Interface + enable chain REST API #610

Merged
merged 22 commits into from
Aug 15, 2023
Merged

More specific test Interface + enable chain REST API #610

merged 22 commits into from
Aug 15, 2023

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Jun 2, 2023

For https://github.com/Reecepbcups/local-interchain (Per my talk with Jack, this will be upstreamed to this repo after the merge of this PR)

Other than this, it is just interface tweaks so I can run without testing.T & compile into a binary. REST API is a nice to have so users can query and build off locally.

Reecepbcups and others added 10 commits May 11, 2023 14:45
commit 35497b6
Author: Reece Williams <[email protected]>
Date:   Fri May 19 16:21:04 2023 -0500

    rename result -> path (of components)

commit 66c2c32
Merge: a01b723 4c903c4
Author: Reece Williams <[email protected]>
Date:   Fri May 19 16:11:18 2023 -0500

    Merge branch 'main' into reece/juno-improvements-v47

commit a01b723
Author: Reece Williams <[email protected]>
Date:   Fri May 19 16:08:24 2023 -0500

    Adds ModifyGenesis generalized Function + test

commit 33d7faf
Author: Reece Williams <[email protected]>
Date:   Fri May 12 11:14:06 2023 -0500

    Remove uneeded BuildProposal arg

commit 62fd485
Author: Reece Williams <[email protected]>
Date:   Fri May 12 11:07:12 2023 -0500

    Adds BuildProposal for govv1

commit 268df1f
Author: Reece Williams <[email protected]>
Date:   Fri May 12 11:04:41 2023 -0500

    comment

commit 80e66c2
Author: Reece Williams <[email protected]>
Date:   Fri May 12 10:27:54 2023 -0500

    makes SubmitProposal public for chains

commit 83b50de
Author: Reece Williams <[email protected]>
Date:   Thu May 11 14:45:28 2023 -0500

    TxCommand gas auto
@Reecepbcups Reecepbcups changed the title WIP - [feat] Local Interchain [feat] Local Interchain Jun 29, 2023
@Reecepbcups Reecepbcups marked this pull request as ready for review June 29, 2023 21:40
@Reecepbcups Reecepbcups requested a review from a team as a code owner June 29, 2023 21:40
@Reecepbcups Reecepbcups changed the title [feat] Local Interchain More specific test Interface + enable chain REST API Jun 29, 2023
// RelayerFactory describes how to start a Relayer.
type RelayerFactory interface {
// Build returns a Relayer associated with the given arguments.
Build(
t *testing.T,
t TestName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidNix
See any issues here?
Reece notes why this is necessary in the description. Would be good to run it by you too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. There is a new interface on line 15 TestName of which *testing.T implements.

I'm betting this abstraction allows us to not care about creating an actual *testing.T when, in the context of this feature, you don't need because you are not making test assertions. Rather, you're trying to spin up a "mini-network" on your machine.

@boojamya boojamya added the BACKPORT backport into all maintained branches label Aug 10, 2023
@DavidNix DavidNix merged commit 4de9155 into strangelove-ventures:main Aug 15, 2023
6 checks passed
mergify bot pushed a commit that referenced this pull request Aug 15, 2023
DavidNix pushed a commit that referenced this pull request Aug 15, 2023
(cherry picked from commit 4de9155)

Co-authored-by: Reece Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BACKPORT backport into all maintained branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants