More specific test Interface + enable chain REST API #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 35497b6 Author: Reece Williams <[email protected]> Date: Fri May 19 16:21:04 2023 -0500 rename result -> path (of components) commit 66c2c32 Merge: a01b723 4c903c4 Author: Reece Williams <[email protected]> Date: Fri May 19 16:11:18 2023 -0500 Merge branch 'main' into reece/juno-improvements-v47 commit a01b723 Author: Reece Williams <[email protected]> Date: Fri May 19 16:08:24 2023 -0500 Adds ModifyGenesis generalized Function + test commit 33d7faf Author: Reece Williams <[email protected]> Date: Fri May 12 11:14:06 2023 -0500 Remove uneeded BuildProposal arg commit 62fd485 Author: Reece Williams <[email protected]> Date: Fri May 12 11:07:12 2023 -0500 Adds BuildProposal for govv1 commit 268df1f Author: Reece Williams <[email protected]> Date: Fri May 12 11:04:41 2023 -0500 comment commit 80e66c2 Author: Reece Williams <[email protected]> Date: Fri May 12 10:27:54 2023 -0500 makes SubmitProposal public for chains commit 83b50de Author: Reece Williams <[email protected]> Date: Thu May 11 14:45:28 2023 -0500 TxCommand gas auto
This reverts commit 83b50de.
Reecepbcups
changed the title
boojamya
reviewed
Aug 10, 2023
| // RelayerFactory describes how to start a Relayer. | ||
| type RelayerFactory interface { | ||
| // Build returns a Relayer associated with the given arguments. | ||
| Build( | ||
| t *testing.T, | ||
| t TestName, |
There was a problem hiding this comment.
@DavidNix
See any issues here?
Reece notes why this is necessary in the description. Would be good to run it by you too.
There was a problem hiding this comment.
This is fine. There is a new interface on line 15 TestName of which *testing.T implements.
I'm betting this abstraction allows us to not care about creating an actual *testing.T when, in the context of this feature, you don't need because you are not making test assertions. Rather, you're trying to spin up a "mini-network" on your machine.
DavidNix
approved these changes
Aug 10, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
(cherry picked from commit 4de9155)
DavidNix
pushed a commit
that referenced
this pull request
Aug 15, 2023
(cherry picked from commit 4de9155) Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/Reecepbcups/local-interchain (Per my talk with Jack, this will be upstreamed to this repo after the merge of this PR)
Other than this, it is just interface tweaks so I can run without testing.T & compile into a binary. REST API is a nice to have so users can query and build off locally.