Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e arbitrary passthrough fix #678

Closed
wants to merge 4 commits into from
Closed

Conversation

agouin
Copy link
Member

@agouin agouin commented Jul 26, 2023

Testing cosmos/ibc-apps#71 PFM fix

Copy link
Member

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is if we really do need complex PFM test for examples with ictest?

I would feel its better to test this complexity in just in ibc-apps, and have a single hop transfer to show it works here, to eliminate flakey test (maybe using Juno's repo vs gaia is better, will see)

@jtieri
Copy link
Member

jtieri commented Sep 22, 2023

My only question is if we really do need complex PFM test for examples with ictest?

I would feel its better to test this complexity in just in ibc-apps, and have a single hop transfer to show it works here, to eliminate flakey test (maybe using Juno's repo vs gaia is better, will see)

I'm actually all in favor of removing some of these examples that have now moved into other repos closer to the code bases that they seek to exercise. Providing links to complicated interchaintest examples in the wild somewhere in the docs should be sufficient

@Reecepbcups
Copy link
Member

Per the above comment and #772, closing

@Reecepbcups Reecepbcups closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants