Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmos): Additional Helpers #687

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

nivasan1
Copy link
Contributor

@nivasan1 nivasan1 commented Aug 9, 2023

In This PR

  • I add functionality for retrieving the ContainerID of tendermint nodes in a cosmos-chain
    • This is useful for copying data / directories from specific nodes
  • I add functionality for Modifying the genesis delegation size / amounts for cosmos chains
    • This is necessary for chains that support tokens scaled by 1e18 (evm-chains)

@nivasan1 nivasan1 requested a review from a team as a code owner August 9, 2023 21:53
@nivasan1 nivasan1 requested a review from boojamya August 9, 2023 21:53
Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@@ -665,7 +669,7 @@ func (tn *ChainNode) AddGenesisAccount(ctx context.Context, address string, gene
command = append(command, "genesis")
}

command = append(command, "add-genesis-account", address, amount)
command = append(command, "add-genesis-account", address, amount, "--chain-id", tn.Chain.Config().ChainID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is chain-id necessary here?

Some tests are showing this flag is not available.

@boojamya boojamya added the BACKPORT backport into all maintained branches label Aug 9, 2023
@boojamya boojamya merged commit 5fdb1e8 into strangelove-ventures:main Aug 10, 2023
6 checks passed
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go
boojamya added a commit that referenced this pull request Aug 11, 2023
* feat(cosmos): Additional Helpers (#687)

* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go

* conflicts

---------

Co-authored-by: Nikhil Vasan <[email protected]>
Co-authored-by: Dan Kanefsky <[email protected]>
boojamya added a commit that referenced this pull request Aug 11, 2023
* feat(cosmos): Additional Helpers (#687)

* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go

* conflicts

---------

Co-authored-by: Nikhil Vasan <[email protected]>
Co-authored-by: Dan Kanefsky <[email protected]>
boojamya added a commit that referenced this pull request Aug 11, 2023
* feat(cosmos): Additional Helpers (#687)

* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go

* conflicts

---------

Co-authored-by: Nikhil Vasan <[email protected]>
Co-authored-by: Dan Kanefsky <[email protected]>
boojamya added a commit that referenced this pull request Aug 11, 2023
* feat(cosmos): Additional Helpers (#687)

* injective / evm fixes

* chain-id flag conditional

(cherry picked from commit 5fdb1e8)

# Conflicts:
#	ibc/types.go

* conflicts

---------

Co-authored-by: Nikhil Vasan <[email protected]>
Co-authored-by: Dan Kanefsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BACKPORT backport into all maintained branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants