Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to pause and resume containers #692

Merged
merged 5 commits into from
Aug 17, 2023
Merged

feat: ability to pause and resume containers #692

merged 5 commits into from
Aug 17, 2023

Conversation

debendraoli
Copy link
Contributor

@debendraoli debendraoli commented Aug 11, 2023 •
edited
Loading

Halting container is helpful to check relay behaviour.

@debendraoli debendraoli requested a review from a team as a code owner August 11, 2023 05:35
@debendraoli debendraoli changed the title feat: ability to pause and resume relayer feat: ability to pause and resume containers Aug 13, 2023
DavidNix
DavidNix reviewed Aug 14, 2023
View reviewed changes
relayer/docker.go Outdated Show resolved Hide resolved
@boojamya boojamya added the BACKPORT backport into all maintained branches label Aug 16, 2023
boojamya
boojamya approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@boojamya boojamya merged commit cc35cd3 into strangelove-ventures:main Aug 17, 2023
6 checks passed
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
@debendraoli @mergify
feat: ability to pause and resume containers (#692)
66c2353 
* feat: ability to pause and resume relayer

* feat: ability to pause node containers

* fix: typo

* rf: return error message when container is not running

---------

Co-authored-by: Dan Kanefsky <[email protected]>
(cherry picked from commit cc35cd3)

# Conflicts:
#	chain/cosmos/chain_node.go
#	chain/cosmos/sidecar.go
#	internal/dockerutil/container_lifecycle.go
#	relayer/docker.go
@mergify mergify bot mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNix DavidNix DavidNix left review comments

@boojamya boojamya boojamya approved these changes

@jtieri jtieri Awaiting requested review from jtieri jtieri is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
BACKPORT backport into all maintained branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debendraoli @DavidNix @boojamya