feat: wiring for additional start args and env #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
Reecepbcups
changed the title
Reecepbcups
added
BACKPORT
boojamya
approved these changes
Jan 9, 2024
| @@ -1306,7 +1314,7 @@ func (tn *ChainNode) CreateNodeContainer(ctx context.Context) error { | |||
| fmt.Printf("Port Overrides: %v. Using: %v\n", chainCfg.HostPortOverride, usingPorts) | |||
| } | |||
|
|
|||
| return tn.containerLifecycle.CreateContainer(ctx, tn.TestName, tn.NetworkID, tn.Image, usingPorts, tn.Bind(), nil, tn.HostName(), cmd, nil) | |||
| return tn.containerLifecycle.CreateContainer(ctx, tn.TestName, tn.NetworkID, tn.Image, usingPorts, tn.Bind(), nil, tn.HostName(), cmd, chainCfg.Env) | |||
There was a problem hiding this comment.
Nice.
This is a bug fix right?
Good eye.
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 0a8a8a2) # Conflicts: # chain/cosmos/chain_node.go # chain/cosmos/sidecar.go # ibc/types.go
Reecepbcups
added a commit
that referenced
this pull request
Feb 2, 2024
* andrew's writing for additional start args and env (#933) (cherry picked from commit 0a8a8a2) # Conflicts: # chain/cosmos/chain_node.go # chain/cosmos/sidecar.go # ibc/types.go * merge v7 + portmap changes * iter for `usingPorts` --------- Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Andrew's branch andrew/env_and_args
I cherry-picked not sure why he is not in the commit