Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rollkit x CelstiaDA #952

Closed
wants to merge 5 commits into from
Closed

feat: Rollkit x CelstiaDA #952

wants to merge 5 commits into from

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Jan 20, 2024

Goal

Launch Celestia DA and a rollkit chain, connect the 2

@Reecepbcups Reecepbcups changed the title feat: rollkit [DNM] feat: Rollkit x CelstiaDA Feb 2, 2024
@chatton
Copy link
Contributor

chatton commented Mar 12, 2024

Awesome work on this so far @Reecepbcups , it's looking good. While working on rollkit integration, we've been basing our work on the same gm-world tutorial (building a rollkit app, using the celestia dev net container etc.)

We're currently using a docker compose file for our local testing, but would love to eventually write proper tests using interchain test once this PR is merged.

Let me know if there's anything I can do to help with this one.

@Reecepbcups
Copy link
Member Author

@chatton I currently don't have any extra bandwidth to work on this atm. Main blocker here is probably something related to docker networking iirc (using n.HostName()). When starting it up, the app is not able to connect to the da/brdige despite it starting up along side.

looking at it now I wonder if core.ip flag needs a port or if the --da.grpc.listen is incorrect. Most likely something small

@chatton
Copy link
Contributor

chatton commented Mar 20, 2024

Hey @Reecepbcups, as a workaround I created the celestia dev net container directly in the test in this PR cosmos/ibc-go#6029, all the containers seem to be working and talking to each other okay, but it seems interchaintest is assuming some default ports and so is is considering the rollup chain not ready.

But the rollkit app is successfully publishing to celestia in this branch of ibc-go. The approach I'm using ATM is a "hackier" one I think since I'm just taking the exist celestia dev net container and letting all the startup scripts already in place work there.

@Reecepbcups
Copy link
Member Author

@chatton If specific ports are required on startup, ibc.ChainConfig has a HostPortOverride map[int]int which will force the internal container port to map to external expected port, rather than randomization.

ChainConfig: ibc.ChainConfig {
 ...
HostPortOverride: map[int]int{
	26657: 26657,
	1317: 1317,
	9090: 9090,
},
}

This may help

@Reecepbcups Reecepbcups changed the title [DNM] feat: Rollkit x CelstiaDA feat: Rollkit x CelstiaDA Apr 2, 2024
@Reecepbcups
Copy link
Member Author

Steve Misko is taking this on in a new PR with better Celestia DA support. Closing for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants