Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] * Copy discount link should copy the code to the clipboard i… #3217

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MaximilianoRicoTabo
Copy link
Contributor

…nstead of open edit page

image

All Submissions:

Changes proposed in this Pull Request:

Resolves XXX.

How to test the changes in this Pull Request:

  1. Click copy link in discount code.
  2. Observe it doesn't open the edit page anymore.
  3. Paste the clipboard content somewhere and compare with the code.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@kimcoleman
Copy link
Member

This link isn’t broken as is. It doesn’t open the edit page. It duplicates the discount code as a new code with same settings.

Let’s discuss whether the word copy is misleading and duplicate is better.

@MaximilianoRicoTabo
Copy link
Contributor Author

Should I close this one then @kimcoleman ?

@kimcoleman
Copy link
Member

We can chat about this in a dev meeting. ‘click to copy’ would be nice some other places in the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants