Fixes #115: Resolve undefined 'link_class' warning for group join button #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes an issue where a warning (Undefined array key "link_class") is triggered in BuddyBoss groups, caused by the absence of the "link_class" key in PHP 8+. The fix uses a null coalescing operator (??) to provide a default empty value, preventing the warning and maintaining compatibility.
Additionally, the order of conditions within the if statement in the callback function of 'bp_get_group_join_button' (pmpro_bp_disable_group_buttons) was corrected, and parentheses were added to ensure the correct evaluation of conditions. The updated condition checks if the user can join the group first before evaluating the presence and value of $button_args['id'], enhancing both readability and accuracy.
How to test the changes in this Pull Request:
Other information:
Changelog entry
Fixes PHP 8+ warning for undefined array key "link_class" in the group join button when group joining is restricted. Adjusted the condition order and added parentheses for clarity and correctness in evaluating conditions.