Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generation error hierarchy #19

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add a generation error hierarchy #19

wants to merge 1 commit into from

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Nov 15, 2018 •
edited
Loading

Related: #10.

@mulkieran
Copy link
Member Author

Looks like we should be catching pyparsing's ParseBaseException. RecursiveGrammarException just doesn't apply here.

@agrover agrover changed the title Add a generation error heirarchy Add a generation error hierarchy Nov 15, 2018
@mulkieran mulkieran mentioned this pull request Jul 30, 2019
Open
@mulkieran
Copy link
Member Author

This PR is still partial, and the new exception isn't being used. It is only relevant if the D-Bus signature is ill-formed and can't be parsed. We can let this go until later.

@mulkieran mulkieran marked this pull request as draft March 10, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mulkieran