Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype of bindgen workaround usage #348

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbaublitz
Copy link
Member

@jbaublitz jbaublitz self-assigned this Mar 6, 2024
@ShayBox
Copy link

ShayBox commented Mar 8, 2024

Thank you for the first usable workaround for this issue in 7 years.
I hope to see progress on 753, but this works very well for now.

EDIT: This works on Linux, but when I try to use it on Windows it just continues to build forever.
EDIT2: It seems this is because I had put my header directly in the bindgen header arg instead of inside a wrapper.h, doing that fixes it for some reason...

@jbaublitz
Copy link
Member Author

@ShayBox I would strongly recommend against using it and for waiting until I put up a PR on Github against bindgen. I'm still ironing out some issues with the code so it is not production ready yet, but would love to get anyone's feedback on the code once the PR is up.

@jbaublitz
Copy link
Member Author

@ShayBox You can now follow along with development here.

@jbaublitz jbaublitz force-pushed the issue-rust-bindgen-753 branch from 4c591b8 to 163f7f3 Compare March 21, 2024 18:38
@jbaublitz jbaublitz force-pushed the issue-rust-bindgen-753 branch from 163f7f3 to 1c4fd5c Compare August 21, 2024 14:10
@jbaublitz jbaublitz requested a review from mulkieran August 21, 2024 14:11
@jbaublitz jbaublitz force-pushed the issue-rust-bindgen-753 branch from 1c4fd5c to 0f9ae82 Compare August 21, 2024 18:09
@jbaublitz jbaublitz force-pushed the issue-rust-bindgen-753 branch from 0f9ae82 to 1cfce92 Compare September 3, 2024 20:25
@mulkieran
Copy link
Member

Related to stratis-storage/project#713 .

@jbaublitz jbaublitz force-pushed the issue-rust-bindgen-753 branch from ffed978 to b15b484 Compare September 4, 2024 14:38
@jbaublitz jbaublitz force-pushed the issue-rust-bindgen-753 branch from b15b484 to 5f51fae Compare November 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: misc
Development

Successfully merging this pull request may close these issues.

3 participants