Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsblk to "stratis pool report" #1002

Closed
wants to merge 9 commits into from

Conversation

bgurney-rh
Copy link
Member

@bgurney-rh bgurney-rh commented Aug 7, 2023

Related: #1000

@bgurney-rh bgurney-rh self-assigned this Aug 7, 2023
@mulkieran
Copy link
Member

@bgurney-rh Be sure to rebase in order to bring in recent changes.

Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase once again, I had to do a Makefile fix. Also, the decision we make regarding sanitizing input to lsblk here will probably apply to stopped pools also.

src/stratis_cli/_actions/_report_pool.py Show resolved Hide resolved
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to abstract over the shared code in list and report modules before we proceed with this directly. There are several things that need abstracting:

  • how we interact with the StoppedPools property
  • how we manage the pool selection can be abstracted further
  • how we handle the UUID formatting, possibly

I'm putting this back in pending for that reason and will think about the StoppedPools property particularly.

@mulkieran
Copy link
Member

@bgurney-rh Plz rebase and resolve conflicts.

@bgurney-rh
Copy link
Member Author

Rebased; the conflict was from from ._utils import get_clevis_info changing to from ._utils import ClevisInfo.

@fsuba
Copy link
Collaborator

fsuba commented Sep 13, 2023

/packit build

@packit-as-a-service
Copy link

Account fsuba has no write access nor is author of PR!

@bgurney-rh
Copy link
Member Author

/packit build

1 similar comment
@fsuba
Copy link
Collaborator

fsuba commented Sep 13, 2023

/packit build

@bgurney-rh
Copy link
Member Author

Rebased, resolved conflicts, and fixed a linting error on this import statement:

from .._stratisd_constants import PoolIdType
************* Module stratis_cli._actions._report_pool
src/stratis_cli/_actions/_report_pool.py:26:0: E0611: No name 'PoolIdType' in module 'stratis_cli._stratisd_constants' (no-name-in-module)

@bgurney-rh
Copy link
Member Author

/packit build

@bgurney-rh
Copy link
Member Author

Superseded by #1039

@bgurney-rh bgurney-rh closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants