-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lsblk to "stratis pool report" #1002
Conversation
ea5f34b
to
6189fc3
Compare
@bgurney-rh Be sure to rebase in order to bring in recent changes. |
6189fc3
to
4843dcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase once again, I had to do a Makefile fix. Also, the decision we make regarding sanitizing input to lsblk here will probably apply to stopped pools also.
4843dcc
to
04c552f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to abstract over the shared code in list and report modules before we proceed with this directly. There are several things that need abstracting:
- how we interact with the StoppedPools property
- how we manage the pool selection can be abstracted further
- how we handle the UUID formatting, possibly
I'm putting this back in pending for that reason and will think about the StoppedPools property particularly.
@bgurney-rh Plz rebase and resolve conflicts. |
2348034
to
0ba3418
Compare
Rebased; the conflict was from |
/packit build |
Account fsuba has no write access nor is author of PR! |
/packit build |
1 similar comment
/packit build |
0ba3418
to
5debd11
Compare
Rebased, resolved conflicts, and fixed a linting error on this import statement:
|
/packit build |
5c571cc
to
a77c89f
Compare
a77c89f
to
1cdc088
Compare
Signed-off-by: mulhern <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
1cdc088
to
6d5c074
Compare
Superseded by #1039 |
Related: #1000