Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post for metadata rework #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Blog post for metadata rework #349

wants to merge 1 commit into from

Conversation

jbaublitz
Copy link
Member

@jbaublitz jbaublitz self-assigned this Jul 26, 2024
@jbaublitz jbaublitz marked this pull request as draft July 26, 2024 20:38
@jbaublitz jbaublitz marked this pull request as ready for review July 29, 2024 15:00
mulkieran
mulkieran requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requests...I expect I'll want one more pass.

content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
@jbaublitz jbaublitz requested a review from mulkieran July 29, 2024 18:05
bmr-cymru
bmr-cymru reviewed Jul 31, 2024
View reviewed changes
content/metadata-rework.md Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
@mulkieran
Copy link
Member

@jbaublitz I'll wait until @bmr-cymru 's comments are addressed, otherwise the blog post becomes a bit of a moving target.

@jbaublitz
Copy link
Member Author

I think I've addressed all of the comments.

mulkieran
mulkieran requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more requests, still going...

content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
mulkieran
mulkieran requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more requests...might need one more iteration.

content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
content/metadata-rework.md Outdated Show resolved Hide resolved
@jbaublitz jbaublitz requested a review from mulkieran August 8, 2024 13:57
@mulkieran mulkieran added this to the Metadata-related milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmr-cymru bmr-cymru bmr-cymru left review comments

@drckeefe drckeefe drckeefe approved these changes

@bgurney-rh bgurney-rh bgurney-rh approved these changes

@mulkieran mulkieran Awaiting requested review from mulkieran

Requested changes must be addressed to merge this pull request.

Assignees

@jbaublitz jbaublitz

Labels
None yet
Projects
2024December
Status: Pending
Milestone
Metadata-related
Development

Successfully merging this pull request may close these issues.
5 participants
@jbaublitz @mulkieran @bmr-cymru @bgurney-rh @drckeefe