Revert allocation transaction committed #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test |
jbaublitz
force-pushed
the
revert-transaction
branch
from
052e31d to
2939c32
Compare
|
/packit test |
1 similar comment
|
/packit test |
mulkieran
requested changes
Nov 6, 2023
jbaublitz
force-pushed
the
revert-transaction
branch
from
2939c32 to
b62424e
Compare
|
I also made one PR revision that appeared to be required to avoid a panic in cases where we incorrectly calculate the amount of space to allocate from the backstore to the thinpool. I bumped into this due to a bug in #3274 that I intend to fix but it seems better to handle that case with an error in case we introduce another bug like that in the future. |
|
Putting back in progress to look into one additional piece brought up by #3274. |
jbaublitz
force-pushed
the
revert-transaction
branch
2 times, most recently
from
47df312 to
63a5aef
Compare
|
/packit test |
|
I think this is ready for final review. |
jbaublitz
force-pushed
the
revert-transaction
branch
from
63a5aef to
2a7a542
Compare
|
/packit test |
jbaublitz
force-pushed
the
revert-transaction
branch
from
2a7a542 to
c4a7e9f
Compare
|
@jbaublitz Plz rebase when you get the chance. |
jbaublitz
force-pushed
the
revert-transaction
branch
from
c4a7e9f to
b7b8a73
Compare
|
/packit test |
mulkieran
approved these changes
Nov 16, 2023
|
@jbaublitz Plz rebase when you get the chance and we can merge this. |
This code has two notable drawbacks that make it better to remove. 1. The code is never used as intended. All requests are immediately followed by a commit. This does not justify the complexity required to maintain the feature. 2. There is an assumption that will likely be broken in future commits related to changes in stacking and metadata. The assumption is that allocations are always driven by the backstore. If this assumption is broken and allocations to reserve space for metadata are performed at layers lower than the backstore, these layers don't have protections against reserving the same space for two separate allocations and then commiting them both.
jbaublitz
force-pushed
the
revert-transaction
branch
from
b7b8a73 to
1c0cd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3274