Fix Clippy 1.75.0 errors #3521
Fix Clippy 1.75.0 errors #3521
Conversation
Signed-off-by: Bryan Gurney <[email protected]>
src/engine/structures/lock.rs
Outdated
| @@ -370,6 +370,7 @@ where | |||
| /// Returns true if: | |||
| /// * The waiting task does not conflict with any already woken tasks. | |||
| /// * The waiting task does not conflict with any locks currently held. | |||
| #[allow(clippy::get_first)] | |||
There was a problem hiding this comment.
Instead of the allow, use front() for get(0).
There was a problem hiding this comment.
OK; now I see it. It turns out that clippy did recommend front(), but it was in a large list of first() recommendations. I'll revert the clippy allow, let this change run through CI, and then rebase to remove the unnecessary allow commit if all tests pass.
|
Cockpit tests failed for commit 3849d76. @martinpitt, @jelly, @mvollmer please check. |
These are just minor lint fixes, so likely the failure is not due to us. |
Signed-off-by: Bryan Gurney <[email protected]>
Clippy 1.75.0 is showing initialize_devices as an unused import, but it is used in a test in strat_engine/liminal/identify.rs. Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
bgurney-rh
force-pushed
the
latest-1.75
branch
from
a2c5cd0 to
d052161
Compare
|
Rebasing to remove the commits that added and reverted |
|
Cockpit tests failed for commit a2c5cd0. @martinpitt, @jelly, @mvollmer please check. |
|
Merging. I think there is something wrong with the testing framework on rawhide. |
|
Cockpit tests failed for commit d052161. @martinpitt, @jelly, @mvollmer please check. |
|
@mulkieran Right, something broke in the storage stack in rawhide yesterday. It's already on our large pile of stuff to look at which broke over the EOY holidays. Sorry for the trouble, please ignore for now -- tests passed on F39, which gives sufficient confidence. Your own |
|
That test is a test that essentially test stratisd's correct response to a storm of udev events. The tests are unfortunately a bit flaky, but also too useful for us to abandon.
|
Related: stratis-storage/project#682