-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try both Clevis and passphrase in /etc/fstab setup #3528
Try both Clevis and passphrase in /etc/fstab setup #3528
Conversation
14e6469
to
bd0a8cc
Compare
@mvollmer I tested this patch and it resolves the linked issue. The one question I had was mainly about whether you had this problem at boot time too. I think we may take a similar approach but I'm not sure. |
@mulkieran I'm putting this in review after testing and bug fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works, but the code was a bit hard to follow.
bd0a8cc
to
02c269b
Compare
@mvollmer I've re-requested your review. I think I've resolved the issues you mentioned. |
02c269b
to
492a89e
Compare
@mvollmer After investigating a little bit more, I can confirm that the same problem affects the initrd scripts, but it's a little bit harder to solve there largely because we have intentionally separated the Clevis unlock method and the passphrase unlock method into separate dracut modules. This is largely because Anaconda does not support Clevis but does support the keyring unlock method for cryptsetup. These are distributed in separate packages as a result so Anaconda could theoretically support one without the other. I'll have to look into whether there's a way to set a flag based on whether executables are present or not in a dracut module. If we did that, we could potentially merge both dracut modules into a single, dynamic one that would also satisfy the requirement for Anaconda. |
@mvollmer We're ready to merge as soon as you're satisfied w/ the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #3349