Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up stratis-dumpmetadata #3530

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Tidy up stratis-dumpmetadata #3530

merged 2 commits into from
Jan 11, 2024

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Jan 6, 2024 •
edited
Loading

@mulkieran mulkieran self-assigned this Jan 6, 2024
@mulkieran mulkieran changed the title Tidy up stratis-utils file Tidy up stratis-utils file and stratis-dumpmetadata Jan 6, 2024
@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch 5 times, most recently from 0de5587 to 1c341af Compare January 9, 2024 17:01
@mulkieran mulkieran changed the title Tidy up stratis-utils file and stratis-dumpmetadata Tidy up stratis-dumpmetadata Jan 9, 2024
@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch from 1c341af to 6dc0535 Compare January 9, 2024 17:44
@bgurney-rh
Copy link
Member

With the current stratisd.spec file, this will fail to build (at 6dc0535) with the following error:

error: no bin target named `stratis-dumpmetadata`.

@bgurney-rh
Copy link
Member

After that, some files that now need to be listed:

error: Installed (but unpackaged) file(s) found:
   /usr/bin/stratisd-tools
   /usr/lib/debug/usr/bin/stratisd-tools-3.7.0~202401091353git6dc05353-D.el9.x86_64.debug
    Installed (but unpackaged) file(s) found:
   /usr/bin/stratisd-tools
   /usr/lib/debug/usr/bin/stratisd-tools-3.7.0~202401091353git6dc05353-D.el9.x86_64.debug

@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch from 6dc0535 to d3868e9 Compare January 9, 2024 20:29
@bgurney-rh bgurney-rh mentioned this pull request Jan 9, 2024
Merged
@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch 4 times, most recently from 60b2b21 to 447b35c Compare January 10, 2024 15:20
@mulkieran mulkieran marked this pull request as ready for review January 10, 2024 15:29
@mulkieran
Put dump-metadata code in separate file
f4df9bc 
Signed-off-by: mulhern <[email protected]>
@mulkieran
Improve dispatch for tools in tools package
f5972db 
* Change name of primary binary to stratisd-tools
* Update CI
* Add struct based dispatch
* Allow invoking stratisd-tools directly with name as subcommand

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch from 447b35c to a1e60dd Compare January 11, 2024 15:42
@mulkieran
Copy link
Member Author

rebased. Need to drop temporary commit before merging, then merge stratis-storage/ci#499 .

@mulkieran mulkieran force-pushed the issue_stratisd_3529 branch from a1e60dd to f5972db Compare January 11, 2024 17:29
@mulkieran mulkieran merged commit 6df7016 into stratis-storage:master Jan 11, 2024
36 of 44 checks passed
@mulkieran mulkieran deleted the issue_stratisd_3529 branch January 11, 2024 17:31
@mulkieran mulkieran mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaublitz jbaublitz jbaublitz approved these changes

@bmr-cymru bmr-cymru bmr-cymru approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mulkieran @bgurney-rh @bmr-cymru @jbaublitz