Version 3.6.4 pre 2 #3533
Closed
Version 3.6.4 pre 2 #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Gurney <[email protected]>
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Clippy 1.75.0 is showing initialize_devices as an unused import, but it is used in a test in strat_engine/liminal/identify.rs. Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: mulhern <[email protected]>
Fix a few clippy errors that crept in. Signed-off-by: mulhern <[email protected]>
The unwrap() should always succeed; make it an expect. Signed-off-by: mulhern <[email protected]>
stratisd does not need to suppress output via -q option to thin_check because the cmd module captures stderr and stdout streams and only reads them if the command returns an error. Signed-off-by: mulhern <[email protected]>
stratisd captures stdout and stderr and will only report the output on a failure of the command. No need to make xfs.mkfs quiet via a command-line option. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.