Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use retry in test #3738

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Use retry in test #3738

merged 5 commits into from
Jan 6, 2025

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Jan 3, 2025 •
edited
Loading

@mulkieran
Use retry crate when tearing down devices
7aff8f1 
Signed-off-by: mulhern <[email protected]>
@mulkieran
Simplify retry operation further
fa4a666 
Include it in the first attempt to remove a DM device.

Signed-off-by: mulhern <[email protected]>
@mulkieran
Check progress in do_while_progress
b489972 
It is less side-effectivey when done there than in one_iteration.

Signed-off-by: mulhern <[email protected]>
@mulkieran
Simplify one_iteration a bit further
165d71a 
Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran self-assigned this Jan 3, 2025
@mulkieran
Use retry crate when checking symlinks
0a83170 
They rely on udev, and so a delay in setting up filesystem symlinks
after pool rename is to be expected.

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran requested a review from bgurney-rh January 3, 2025 20:24
@mulkieran mulkieran marked this pull request as ready for review January 3, 2025 20:24
bgurney-rh
bgurney-rh approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@bgurney-rh bgurney-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a test run of runalltests.sh from the ci repo, I no longer see the "real_test_pool_rename" test failing.

@mulkieran
Copy link
Member Author

Looks like packit/TMT is hung for some reason...

@packit-as-a-service Packit-as-a-Service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3738
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran merged commit 9452962 into stratis-storage:master Jan 6, 2025
46 checks passed
@mulkieran mulkieran deleted the use-retry-in-test branch January 6, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgurney-rh bgurney-rh bgurney-rh approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
No open projects
2024December
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mulkieran @bgurney-rh