Have strat engine verify existence of required binaries #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume that all binaries will be required by stratisd at some time, and that it shouldn't run if they are not available. This seems better to me than having a panic if we try to use them and they are not needed. Hoist cmd.rs up a level, since it seems like the engine really has to interact with it. Postpone dealing with the fact that not all these binaries will actually be available in the initramfs. Signed-off-by: mulhern <[email protected]>
|
Supercedes #974 . Code is identical, but comment on |
Closed
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume that all binaries will be required by stratisd at some time,
and that it shouldn't run if they are not available.
This seems better to me than having a panic if we try to use them and they
are not needed.
Hoist cmd.rs up a level, since it seems like the engine really has to
interact with it.
Postpone dealing with the fact that not all these binaries will actually
be available in the initramfs.
Signed-off-by: mulhern [email protected]