-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StratisCertify tests for snapshot revert #281
Add StratisCertify tests for snapshot revert #281
Conversation
The cancel-revert test seems like the only test that I can add right now, as the others would have remnants that clean_up() can't handle right now:
...and I had to manually run "stratis fs cancel-revert" for the remnant filesystem snapshot. |
We'll need to augment the cleanup method with a step to unset all merge fields before we can proceed with the stratis-cli tests. |
358dc63
to
6a102c0
Compare
I found a way to get the clean_up() method to run, but it took some rework. Re-ordered commits to have this rework done first, before adding the first test. |
Not quite working yet; for some reason, the |
528cce0
to
1fadd78
Compare
Rebasing, putting all of the testlib additions/fixes in the first commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one requested change. You might as well go on and add a stratis_cert.py test as well and then this should be done.
Looks good |
5cad102
to
f1935c1
Compare
Rebased, to squash |
f1935c1
to
523ac24
Compare
Also refine the StratisDbus.fs_list() method to return the object path, which is used to unset the MergeScheduled field for filesystems being torn down after a test. Also, rename StratisDbus.pool_set_property to set_property Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
Signed-off-by: Bryan Gurney <[email protected]>
523ac24
to
18cc604
Compare
Rebased. |
Related: #280