remove sv2-ffi crate

stratum-mining · Jan 29, 2025 · 2ef3fda · 2ef3fda
1 parent 8b190e7
commit 2ef3fda
Show file tree

Hide file tree

Showing 11 changed files with 3 additions and 2,088 deletions.
diff --git a/.github/workflows/coverage-protocols.yaml b/.github/workflows/coverage-protocols.yaml
@@ -118,14 +118,6 @@ jobs:
           flags: v1-coverage
           token: ${{ secrets.CODECOV_TOKEN }}
 
-      - name: Upload sv2_ffi-coverage to codecov.io
-        uses: codecov/codecov-action@v4
-        with:
-          directory: ./protocols/target/tarpaulin-reports/sv2-ffi-coverage
-          file: ./protocols/target/tarpaulin-reports/sv2-ffi-coverage/cobertura.xml
-          flags: sv2_ffi-coverage
-          token: ${{ secrets.CODECOV_TOKEN }}
-
       - name: Upload template_distribution_sv2-coverage to codecov.io
         uses: codecov/codecov-action@v4
         with:

diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml
@@ -94,11 +94,6 @@ jobs:
           cd protocols/v2/subprotocols/template-distribution
           cargo doc
 
-      - name: Rust Docs crate sv2_ffi
-        run: |
-          cd protocols/v2/sv2-ffi
-          cargo doc
-
       - name: Rust Docs crate roles_logic_sv2
 
         run: |

diff --git a/.github/workflows/release-libs.yaml b/.github/workflows/release-libs.yaml
@@ -85,10 +85,6 @@ jobs:
         run: |
           ./scripts/release-libs.sh protocols/v2/subprotocols/template-distribution
 
-      - name: Publish crate sv2_ffi
-        run: |
-          ./scripts/release-libs.sh protocols/v2/sv2-ffi
-
       - name: Publish crate roles_logic_sv2
         run: |
           ./scripts/release-libs.sh protocols/v2/roles-logic-sv2

diff --git a/.github/workflows/semver-check.yaml b/.github/workflows/semver-check.yaml
@@ -93,10 +93,6 @@ jobs:
         working-directory: protocols/v2/subprotocols/template-distribution
         run: cargo semver-checks
 
-      - name: Run semver checks for protocols/v2/sv2-ffi
-        working-directory: protocols/v2/sv2-ffi
-        run: cargo semver-checks
-
       - name: Run semver checks for protocols/v2/roles-logic-sv2
         working-directory: protocols/v2/roles-logic-sv2
         run: cargo semver-checks --default-features

diff --git a/protocols/Cargo.toml b/protocols/Cargo.toml
@@ -16,7 +16,6 @@ members = [
     "v2/subprotocols/template-distribution",
     "v2/subprotocols/mining",
     "v2/subprotocols/job-declaration",
-    "v2/sv2-ffi",
     "v2/roles-logic-sv2",
 ]
 

diff --git a/protocols/v2/const-sv2/src/lib.rs b/protocols/v2/const-sv2/src/lib.rs
@@ -60,16 +60,16 @@ pub const SV2_FRAME_CHUNK_SIZE: usize = 65535;
 pub const AEAD_MAC_LEN: usize = 16;
 
 /// Size of the encrypted SV2 frame header, including the MAC.
-// Refactoring: declared in sv2-ffi, and imported in framing_sv2/src/header.rs
+// Refactoring: imported in framing_sv2/src/header.rs
 // header.rs is then imported into codec_sv2 just for this constant
 pub const ENCRYPTED_SV2_FRAME_HEADER_SIZE: usize = SV2_FRAME_HEADER_SIZE + AEAD_MAC_LEN;
 
 /// Size of the Noise protocol frame header in bytes.
-// Refactoring: declared in sv2-ffi, and imported in framing_sv2/src/header.rs
+// Refactoring: imported in framing_sv2/src/header.rs
 // header.rs is then imported into codec_sv2 just for this constant
 pub const NOISE_FRAME_HEADER_SIZE: usize = 2;
 
-// Refactoring: declared in sv2-ffi, and imported in framing_sv2/src/header.rs
+// Refactoring: imported in framing_sv2/src/header.rs
 // header.rs is then imported into codec_sv2 just for this constant, and the
 // const there is not even used
 pub const NOISE_FRAME_HEADER_LEN_OFFSET: usize = 0;

diff --git a/protocols/v2/sv2-ffi/Cargo.toml b/protocols/v2/sv2-ffi/Cargo.toml